[Metricbeat] Further revise check for bad data in docker/memory #17400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Apparently, as I discovered in discuss, there are platforms where there's no cgroup memory data, and thus no memory stats for docker to send us. In this case, we were still sending
NaN
s to the output because of the&&
check.Why is it important?
We don't want to send data with NaNs to the output.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
There's an added test. People have been reporting this bug against CentOS, but I haven't been able to reproduce it myself, as it appears to be a cgroup quirk.