Cherry-pick #17400 to 7.x: [Metricbeat] Further revise check for bad data in docker/memory #17446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#17400) * use OR to check for missing data and report lack of memory data * add changelog entry * remove space (cherry picked from commit b80066c)
ycombinator
reviewed
Apr 2, 2020
CHANGELOG.next.asciidoc
Outdated
| @@ -178,6 +178,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Use max in k8s overview dashboard aggregations. {pull}17015[17015] | |||
| - Fix Disk Used and Disk Usage visualizations in the Metricbeat System dashboards. {issue}12435[12435] {pull}17272[17272] | |||
| - Fix missing Accept header for Prometheus and OpenMetrics module. {issue}16870[16870] {pull}17291[17291] | |||
| - Further revise check for bad data in docker/memory. {pull}17400[17400] | |||
| - Fix issue in Jolokia module when mbean contains multiple quoted properties. {issue}17375[17375] {pull}17374[17374] | |||
|
It looks like this PR was already merged but, for some reason, just not closed. So closing it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #17400 to 7.x branch. Original message:
What does this PR do?
Apparently, as I discovered in discuss, there are platforms where there's no cgroup memory data, and thus no memory stats for docker to send us. In this case, we were still sending
NaNs to the output because of the&&check.Why is it important?
We don't want to send data with NaNs to the output.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
There's an added test. People have been reporting this bug against CentOS, but I haven't been able to reproduce it myself, as it appears to be a cgroup quirk.