-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic cloudfoundry integration tests #19018
Merged
jsoriano
merged 4 commits into
elastic:master
from
jsoriano:cloudfoundry-integration-tests
Jun 12, 2020
Merged
Add basic cloudfoundry integration tests #19018
jsoriano
merged 4 commits into
elastic:master
from
jsoriano:cloudfoundry-integration-tests
Jun 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
review
:Testing
[zube]: In Review
Team:Platforms
Label for the Integrations - Platforms team
labels
Jun 5, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 5, 2020
jenkins, run the tests please |
8 tasks
blakerouse
approved these changes
Jun 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Really like the testing!
jsoriano
added
needs_backport
PR is waiting to be backported to other branches.
v7.9.0
labels
Jun 12, 2020
6 tasks
jsoriano
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Jun 12, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jun 12, 2020
(cherry picked from commit 600f5a8)
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 15, 2020
…ngs-archive * upstream/master: Fix minor spelling error in Jenkinsfile (elastic#19153) [CI] fail if not possible to install python3 (elastic#19164) [Elastic Agent] Improved mage demo experience (elastic#18445) [yum] Clear cached data and add retry loop (elastic#19182) fix lint job by updating NOTICE (elastic#19161) Fix tags for coredns/envoyproxy (elastic#19134) Disable host.* fields by default for CrowdStrike module (elastic#19132) Allow host.* fields to be disabled in Zeek module (elastic#19113) Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114) Edit Elastic Agent docs (elastic#19146) [JJBB] create job definition for the golang-crossbuild project (elastic#19162) Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052) Add basic cloudfoundry integration tests (elastic#19018)
jsoriano
added a commit
that referenced
this pull request
Jun 15, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add some basic integration tests for cloudfoundry.
By now these tests follow the approach we are following with cloud features, they need a cloud foundry deployment whose configuration is provided using environment variables, and tests are only executed if some tag is set. So they are not going to be executed in CI by now.
Instructions to have a working cloud foundry deployment will be added in a future PR.
Why is it important?
To have some integration tests as reference before starting with further refactors.
Checklist
I have made corresponding changes to the documentationInstructions to have a cloud foundry deployment for development will be added in a future PR.I have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues