-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yum] Clear cached data and add retry loop #19182
Conversation
This commit makes the yum commands more robust by: - clearing the cache after the install command is finished - adding a retry loop so that the installation is retried in case of transient network issues Without this fix, the Unified Release Process can't complete any Stack/Solution snapshots or staging builds because of the following error: ``` "[Errno -1] repomd.xml does not match metalink for epel" ``` This is related to this [Slack discussion for building the 7.8.0 BC7](https://elastic.slack.com/archives/C0JFN9HJL/p1592055371477200) and related to this https://serverfault.com/questions/1021273/yum-install-jq-is-failing-intermittently-on-centos7 This is inspired by what the Elasticsearch team is doing for building the Elasticsearch Docker image - https://github.com/elastic/dockerfiles/blob/a5749cb11d8b38491c40efa476c576ab60a3a9f8/elasticsearch/Dockerfile#L16
This pull request doesn't have a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
--------------------- >> end captured stdout << ----------------------
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
@mikemadden42 Thanks for the review, let me know if I can merge it even if some tests are failing |
@mgreau I'll go ahead & merge it. I do not believe any of our tests would exercise this change. |
Thank you! Let me know if I need to do the backport(PR?) for having it in 7.8 |
This commit makes the yum commands more robust by: - clearing the cache after the install command is finished - adding a retry loop so that the installation is retried in case of transient network issues Without this fix, the Unified Release Process can't complete any Stack/Solution snapshots or staging builds because of the following error: ``` "[Errno -1] repomd.xml does not match metalink for epel" ``` This is related to this [Slack discussion for building the 7.8.0 BC7](https://elastic.slack.com/archives/C0JFN9HJL/p1592055371477200) and related to this https://serverfault.com/questions/1021273/yum-install-jq-is-failing-intermittently-on-centos7 This is inspired by what the Elasticsearch team is doing for building the Elasticsearch Docker image - https://github.com/elastic/dockerfiles/blob/a5749cb11d8b38491c40efa476c576ab60a3a9f8/elasticsearch/Dockerfile#L16
@mikemadden42 I opened #19184 |
This commit makes the yum commands more robust by: - clearing the cache after the install command is finished - adding a retry loop so that the installation is retried in case of transient network issues Without this fix, the Unified Release Process can't complete any Stack/Solution snapshots or staging builds because of the following error: ``` "[Errno -1] repomd.xml does not match metalink for epel" ``` This is related to this [Slack discussion for building the 7.8.0 BC7](https://elastic.slack.com/archives/C0JFN9HJL/p1592055371477200) and related to this https://serverfault.com/questions/1021273/yum-install-jq-is-failing-intermittently-on-centos7 This is inspired by what the Elasticsearch team is doing for building the Elasticsearch Docker image - https://github.com/elastic/dockerfiles/blob/a5749cb11d8b38491c40efa476c576ab60a3a9f8/elasticsearch/Dockerfile#L16
…ngs-archive * upstream/master: Fix minor spelling error in Jenkinsfile (elastic#19153) [CI] fail if not possible to install python3 (elastic#19164) [Elastic Agent] Improved mage demo experience (elastic#18445) [yum] Clear cached data and add retry loop (elastic#19182) fix lint job by updating NOTICE (elastic#19161) Fix tags for coredns/envoyproxy (elastic#19134) Disable host.* fields by default for CrowdStrike module (elastic#19132) Allow host.* fields to be disabled in Zeek module (elastic#19113) Rename to management.Manager, add UpdateStatus to Manager interface. (elastic#19114) Edit Elastic Agent docs (elastic#19146) [JJBB] create job definition for the golang-crossbuild project (elastic#19162) Fix incorrect usage of hints builder when exposed port is a substring of the hint (elastic#19052) Add basic cloudfoundry integration tests (elastic#19018)
This commit makes the yum commands more robust by: - clearing the cache after the install command is finished - adding a retry loop so that the installation is retried in case of transient network issues Without this fix, the Unified Release Process can't complete any Stack/Solution snapshots or staging builds because of the following error: ``` "[Errno -1] repomd.xml does not match metalink for epel" ``` This is related to this [Slack discussion for building the 7.8.0 BC7](https://elastic.slack.com/archives/C0JFN9HJL/p1592055371477200) and related to this https://serverfault.com/questions/1021273/yum-install-jq-is-failing-intermittently-on-centos7 This is inspired by what the Elasticsearch team is doing for building the Elasticsearch Docker image - https://github.com/elastic/dockerfiles/blob/a5749cb11d8b38491c40efa476c576ab60a3a9f8/elasticsearch/Dockerfile#L16
What does this PR do?
This commit makes the yum commands more robust by:
This is inspired by what the Elasticsearch team is doing for building the Elasticsearch Docker image
Why is it important?
Without this fix, the Unified Release Process can't complete any Stack/Solution snapshots or staging builds because of the following error:
This is related to this https://serverfault.com/questions/1021273/yum-install-jq-is-failing-intermittently-on-centos7
@andrewkroh I don't know how to test it.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.