Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #19335 to 7.x: Fix fortinet.firewall.mem value to be interpreted as integer #20542

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Cherry-pick #19335 to 7.x: Fix fortinet.firewall.mem value to be interpreted as integer #20542

merged 1 commit into from
Aug 11, 2020

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Aug 11, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #19335 to 7.x branch. Original message:

What does this PR do?

Interpret fortinet.firewall.mem as integer instead of keyword

Why is it important?

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Run filebeat tests locally e.g.

./filebeat.test GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=fortinet nosetests tests/system/test_modules.py

PYTEST_ADDOPTS="-k fortinet" mage -v pythonIntegTest

Related issues

@philippkahr @andrewkroh
Fix fortinet.firewall.mem value to be interpreted as integer (elastic…
8cd7c0c 
…#19335)

Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline.

Closes elastic#19327

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
(cherry picked from commit e7c0b1d)
@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 11, 2020
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20542 opened]

  • Start Time: 2020-08-11T11:33:04.816+0000

  • Duration: 97 min 3 sec

Test stats 🧪

Test Results
Failed 0
Passed 5501
Skipped 703
Total 6204

Steps errors

Expand to view the steps failures

  • Name: Mage build unitTest

    • Description: mage build unitTest

    • Duration: 7 min 2 sec

    • Start Time: 2020-08-11T13:02:35.910+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-08-11T12:36:45.973Z] Client: Docker Engine - Community
[2020-08-11T12:36:45.973Z]  Version:           19.03.1
[2020-08-11T12:36:45.973Z]  API version:       1.40
[2020-08-11T12:36:45.973Z]  Go version:        go1.12.5
[2020-08-11T12:36:45.973Z]  Git commit:        74b1e89
[2020-08-11T12:36:45.974Z]  Built:             Thu Jul 25 21:18:17 2019
[2020-08-11T12:36:45.974Z]  OS/Arch:           darwin/amd64
[2020-08-11T12:36:45.974Z]  Experimental:      false
[2020-08-11T12:36:45.974Z] Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
[2020-08-11T12:36:45.974Z] It requires Docker daemon to be installed and running
[2020-08-11T13:02:35.771Z] python not installed. An error occurred during installation:
[2020-08-11T13:02:35.771Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-08-11T13:02:35.771Z] python package files install completed. Performing other installation steps.
[2020-08-11T13:02:35.771Z] The install of python was NOT successful.
[2020-08-11T13:02:35.771Z] python not installed. An error occurred during installation:
[2020-08-11T13:02:35.771Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-08-11T13:02:35.771Z] 
[2020-08-11T13:02:35.771Z] Chocolatey installed 0/1 packages. 1 packages failed.
[2020-08-11T13:02:35.771Z]  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
[2020-08-11T13:02:35.771Z] 
[2020-08-11T13:02:35.771Z] Failures
[2020-08-11T13:02:35.771Z]  - python (exited 1) - python not installed. An error occurred during installation:
[2020-08-11T13:02:35.771Z]  Unable to read package from path 'python3.3.8.2.nupkg'.
[2020-08-11T13:02:35.771Z] ERROR 
[2020-08-11T13:02:35.869Z] Running in C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\x-pack\filebeat
[2020-08-11T13:02:36.205Z] 
[2020-08-11T13:02:36.205Z] C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\x-pack\filebeat>mage  build unitTest 
[2020-08-11T13:03:43.870Z] >> build: Building filebeat
[2020-08-11T13:05:35.302Z] >> go test: Unit Testing
[2020-08-11T13:08:41.770Z] SUMMARY:
[2020-08-11T13:08:41.770Z]   Fail:     0
[2020-08-11T13:08:41.770Z]   Skip:     7
[2020-08-11T13:08:41.770Z]   Pass:     549
[2020-08-11T13:08:41.770Z]   Packages: 20
[2020-08-11T13:08:41.770Z]   Duration: 3m13.3442494s
[2020-08-11T13:08:41.770Z]   Coverage Report: C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.html
[2020-08-11T13:08:41.770Z]   JUnit Report:    C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.xml
[2020-08-11T13:08:41.770Z]   Output File:     C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\x-pack\filebeat\build\TEST-go-unit.out
[2020-08-11T13:08:41.770Z] >> go test: Unit Test Passed
[2020-08-11T13:09:37.970Z] >> python test: Unit Testing
[2020-08-11T13:09:37.970Z] C:\Python27\python.exe: No module named venv
[2020-08-11T13:09:37.970Z] Error: running "python -m venv C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\build\ve\windows" failed with exit code 1
[2020-08-11T13:09:38.454Z] 
[2020-08-11T13:09:38.454Z] C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats>python .ci/scripts/pre_archive_test.py 
[2020-08-11T13:09:39.017Z] Copy .\x-pack\filebeat\build into build\x-pack\filebeat\build
[2020-08-11T13:09:39.042Z] Running in C:\Users\jenkins\workspace\Beats_beats_PR-20542\src\github.com\elastic\beats\build
[2020-08-11T13:09:39.093Z] Recording test results
[2020-08-11T13:09:40.134Z] Stashed 1 file(s)
[2020-08-11T13:09:40.153Z] Archiving artifacts
[2020-08-11T13:09:40.790Z] [INFO] system-tests=''. If no empty then let's create a tarball
[2020-08-11T13:09:42.532Z] Failed in branch Filebeat x-pack Windows
[2020-08-11T13:09:44.408Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats
[2020-08-11T13:09:44.755Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-08-11T13:09:44.780Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Lint
[2020-08-11T13:09:44.964Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-Windows
[2020-08-11T13:09:45.136Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-oss
[2020-08-11T13:09:45.299Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-x-pack
[2020-08-11T13:09:45.468Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-Mac-OS-X
[2020-08-11T13:09:45.634Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-x-pack-Mac-OS-X
[2020-08-11T13:09:45.798Z] Running in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats/Filebeat-x-pack-Windows
[2020-08-11T13:09:46.250Z] + cat
[2020-08-11T13:09:46.250Z] + /usr/local/bin/runbld ./runbld-script
[2020-08-11T13:09:46.250Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-08-11T13:09:52.825Z] runbld>>> runbld started
[2020-08-11T13:09:52.825Z] runbld>>> 1.6.12/f45d832f2ba0aa2722ab4ec1fda8ad140f027f8b
[2020-08-11T13:09:53.763Z] runbld>>> The following profiles matched the job 'Beats/beats/PR-20542' in order of occurrence in the config (last value wins).
[2020-08-11T13:09:55.138Z] runbld>>> Debug logging enabled.
[2020-08-11T13:09:55.138Z] runbld>>> Storing result
[2020-08-11T13:09:55.397Z] runbld>>> Store result: created {:total 2, :successful 2, :failed 0} 1
[2020-08-11T13:09:55.397Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200811130954-E286C020
[2020-08-11T13:09:55.397Z] runbld>>> Adding system facts.
[2020-08-11T13:09:56.334Z] runbld>>> Adding vcs info for the latest commit:  8cd7c0c5ff46816c6a0a2c15ec1e6726adf09e08
[2020-08-11T13:09:56.334Z] runbld>>> >>>>>>>>>>>> SCRIPT EXECUTION BEGIN >>>>>>>>>>>>
[2020-08-11T13:09:56.334Z] runbld>>> Adding /usr/lib/jvm/java-8-openjdk-amd64/bin to the path.
[2020-08-11T13:09:56.334Z] + echo 'Processing JUnit reports with runbld...'
[2020-08-11T13:09:56.334Z] Processing JUnit reports with runbld...
[2020-08-11T13:09:56.901Z] runbld>>> <<<<<<<<<<<< SCRIPT EXECUTION END <<<<<<<<<<<<
[2020-08-11T13:09:56.901Z] runbld>>> DURATION: 40ms
[2020-08-11T13:09:56.901Z] runbld>>> STDOUT: 40 bytes
[2020-08-11T13:09:56.901Z] runbld>>> STDERR: 49 bytes
[2020-08-11T13:09:56.901Z] runbld>>> WRAPPED PROCESS: SUCCESS (0)
[2020-08-11T13:09:56.901Z] runbld>>> Searching for build metadata in /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats
[2020-08-11T13:09:57.837Z] runbld>>> Storing build metadata: 
[2020-08-11T13:09:57.837Z] runbld>>> Adding test report.
[2020-08-11T13:09:57.837Z] runbld>>> Searching for junit test output files with the pattern: TEST-.*\.xml$ in: /var/lib/jenkins/workspace/Beats_beats_PR-20542/src/github.com/elastic/beats
[2020-08-11T13:09:58.772Z] runbld>>> Found 15 test output files
[2020-08-11T13:10:00.156Z] runbld>>> Test output logs contained: Errors: 0 Failures: 0 Tests: 6204 Skipped: 677
[2020-08-11T13:10:00.156Z] runbld>>> Storing result
[2020-08-11T13:10:00.156Z] runbld>>> FAILURES: 0
[2020-08-11T13:10:00.415Z] runbld>>> Store result: updated {:total 2, :successful 2, :failed 0} 2
[2020-08-11T13:10:00.415Z] runbld>>> BUILD: https://c150076387b5421f9154dfbf536e5c60.us-west1.gcp.cloud.es.io:9243/build-1587637540455/t/20200811130954-E286C020
[2020-08-11T13:10:00.673Z] runbld>>> Email notification disabled by environment variable.
[2020-08-11T13:10:00.673Z] runbld>>> Slack notification disabled by environment variable.
[2020-08-11T13:10:06.282Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats_PR-20542
[2020-08-11T13:10:06.452Z] [INFO] getVaultSecret: Getting secrets
[2020-08-11T13:10:06.540Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-11T13:10:07.728Z] + chmod 755 generate-build-data.sh
[2020-08-11T13:10:07.728Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20542/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20542/runs/1 FAILURE 5822640
[2020-08-11T13:10:07.728Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20542/runs/1/steps/?limit=10000 -o steps-info.json
[2020-08-11T13:10:08.279Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats/PR-20542/runs/1/tests/?status=FAILED -o tests-errors.json

@andrewkroh andrewkroh merged commit 9a3bef6 into elastic:7.x Aug 11, 2020
@zube zube bot removed the [zube]: Done label Nov 10, 2020
@andrewkroh andrewkroh deleted the backport_19335_7.x branch January 14, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewkroh @elasticmachine @philippkahr