Fix fortinet.firewall.mem value to be interpreted as integer #19335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
botelastic
bot
added
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
removed
the
needs_team
|
Can confirm this change is good. Else you wont be able to aggregate on the value. |
|
jenkins run tests |
andrewkroh
approved these changes
Aug 10, 2020
andrewkroh
added
breaking change
bug
Filebeat
andrewkroh
pushed a commit
to andrewkroh/beats
that referenced
this pull request
Aug 11, 2020
…#19335) Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline. Closes elastic#19327 Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co> (cherry picked from commit e7c0b1d)
Merged
3 tasks
andrewkroh
added
v7.10.0
and removed
needs_backport
v1v
added a commit
to v1v/beats
that referenced
this pull request
Aug 12, 2020
…ne-2.0 * upstream/master: (39 commits) [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558) [Heartbeat] Fix packaging (elastic#20566) [Heartbeat] Add Magefile to X-Pack (elastic#20549) [Packetbeat] Add "network" to event.category (elastic#20392) fix typo in docs (elastic#20541) Add service resource in k8s cluster role (elastic#20546) Update Golang version to 1.14.7 (elastic#20508) Add missing inputs to filebeat spec (elastic#20388) add warning log in aws and googlecloud module for API cost (elastic#20523) Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335) [CI] add more resilience (elastic#20505) [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537) [ITs] change healthcheck for elasticsearch (elastic#20514) [JJBB] fix credentials with a service account (elastic#20535) chore(ci): use build step for checking if is PR (elastic#20536) [CI] runbld project name (elastic#20466) Add panw.panos.endreason field (elastic#18705) [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808) Fix typo in netflow module docs (elastic#18992) Modified auditd ingest pipeline to handle node=hostname (elastic#19659) ...
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…#19335) Fix fortinet.firewall.mem value to be interpreted as integer. Add convert processor for fortinet.firewall.mem to ingest pipeline. Closes elastic#19327 Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Interpret fortinet.firewall.mem as integer instead of keyword
Why is it important?
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run filebeat tests locally e.g.
./filebeat.test GENERATE=1 INTEGRATION_TESTS=1 BEAT_STRICT_PERMS=false TESTING_FILEBEAT_MODULES=fortinet nosetests tests/system/test_modules.pyPYTEST_ADDOPTS="-k fortinet" mage -v pythonIntegTestRelated issues