Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service resource in k8s cluster role #20546

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

ChrsMark
Copy link
Member

What does this PR do?

Trying to investigate #20544 I hit:

E0811 12:35:43.768618      90 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.3/tools/cache/reflector.go:125: Failed to list *v1.Service: services is forbidden: User "system:serviceaccount:kube-system:metricbeat" cannot list resource "services" in API group "" at the cluster scope

Why is it important?

To make service watcher work on cluster scope.

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested a review from jsoriano August 11, 2020 12:45
@ChrsMark ChrsMark self-assigned this Aug 11, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 11, 2020
@botelastic
Copy link

botelastic bot commented Aug 11, 2020

This pull request doesn't have a Team:<team> label.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Signed-off-by: chrismark <chrismarkou92@gmail.com>
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20546 updated]

  • Start Time: 2020-08-11T12:48:17.595+0000

  • Duration: 57 min 58 sec

@ChrsMark ChrsMark merged commit 0041246 into elastic:master Aug 11, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Aug 11, 2020
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Aug 11, 2020
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Aug 11, 2020
ChrsMark added a commit that referenced this pull request Aug 11, 2020
…20552)

* Add service resource in k8s cluster role (#20546)


(cherry picked from commit 0041246)

* Update CHANGELOG.next.asciidoc
ChrsMark added a commit that referenced this pull request Aug 11, 2020
…20553)

* Add service resource in k8s cluster role (#20546)


(cherry picked from commit 0041246)

* Update CHANGELOG.next.asciidoc
v1v added a commit to v1v/beats that referenced this pull request Aug 12, 2020
…ne-2.0

* upstream/master: (39 commits)
  [ITs] Revert healthcheck for elasticsearchssl service to the previous behaviour (elastic#20558)
  [Heartbeat] Fix packaging (elastic#20566)
  [Heartbeat] Add Magefile to X-Pack (elastic#20549)
  [Packetbeat] Add "network" to event.category (elastic#20392)
  fix typo in docs (elastic#20541)
  Add service resource in k8s cluster role (elastic#20546)
  Update Golang version to 1.14.7 (elastic#20508)
  Add missing inputs to filebeat spec (elastic#20388)
  add warning log in aws and googlecloud module for API cost (elastic#20523)
  Fix fortinet.firewall.mem value to be interpreted as integer (elastic#19335)
  [CI] add more resilience (elastic#20505)
  [JJBB] fix credentials with a service account for golang-crossbuild (elastic#20537)
  [ITs] change healthcheck for elasticsearch (elastic#20514)
  [JJBB] fix credentials with a service account (elastic#20535)
  chore(ci): use build step for checking if is PR (elastic#20536)
  [CI] runbld project name (elastic#20466)
  Add panw.panos.endreason field (elastic#18705)
  [Filebeat] Fix PANW field spelling "veredict" to "verdict" (elastic#18808)
  Fix typo in netflow module docs (elastic#18992)
  Modified auditd ingest pipeline to handle node=hostname (elastic#19659)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
… role (elastic#20553)

* Add service resource in k8s cluster role (elastic#20546)


(cherry picked from commit e9b5b16)

* Update CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants