Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #20546 to 7.x: Add service resource in k8s cluster role #20552

Merged
merged 2 commits into from
Aug 11, 2020

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Aug 11, 2020

Cherry-pick of PR #20546 to 7.x branch. Original message:

What does this PR do?

Trying to investigate #20544 I hit:

E0811 12:35:43.768618      90 reflector.go:178] pkg/mod/k8s.io/client-go@v0.18.3/tools/cache/reflector.go:125: Failed to list *v1.Service: services is forbidden: User "system:serviceaccount:kube-system:metricbeat" cannot list resource "services" in API group "" at the cluster scope

Why is it important?

To make service watcher work on cluster scope.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 11, 2020
@botelastic
Copy link

botelastic bot commented Aug 11, 2020

This pull request doesn't have a Team:<team> label.

@@ -178,6 +178,8 @@ field. You can revert this change by configuring tags for the module and omittin
- Remove unnecessary restarts of metricsets while using Node autodiscover {pull}19974[19974]
- Output errors when Kibana index pattern setup fails. {pull}20121[20121]
- Fix issue in autodiscover that kept inputs stopped after config updates. {pull}20305[20305]
- Log debug message if the Kibana dashboard can not be imported from the archive because of the invalid archive directory structure {issue}12211[12211], {pull}13387[13387]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra changelog 😄

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 11, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20552 updated]

  • Start Time: 2020-08-11T14:20:42.131+0000

  • Duration: 54 min 4 sec

@ChrsMark ChrsMark merged commit 21fee14 into elastic:7.x Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants