Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add processor.event info to Logstash output #20721

Merged
merged 5 commits into from
Sep 1, 2020

Conversation

bmorelli25
Copy link
Member

What does this PR do?

This PR adds information about processor.event to the Logstash output documentation. Previously, APM Server examples used %{[processor][event]}, but didn't do a good job of explaining why it was necessary. This PR also makes a few grammatical changes and switches from the hardcoded Logstash to the attribute, {ls}.

Why is it important?

This content is important because APM events should be stored in separate indices based on their event type -- which can be determined by looking at processor.event.

Related issues

Closes elastic/apm-server#3705.

@bmorelli25 bmorelli25 requested a review from a team August 20, 2020 20:31
@bmorelli25 bmorelli25 self-assigned this Aug 20, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 20, 2020
@zube zube bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 20, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 20, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 20, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20721 updated]

  • Start Time: 2020-08-31T23:19:49.686+0000

  • Duration: 23 min 38 sec

@andresrc andresrc added the Team:Docs Label for the Observability docs team label Aug 21, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 21, 2020
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Made some suggestions to clean up other Logstash and Elasticsearch references, but GitHub wouldn't let me add suggestions to all occurrences. It's up to you whether you clean them up.

libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
libbeat/outputs/logstash/docs/logstash.asciidoc Outdated Show resolved Hide resolved
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@bmorelli25
Copy link
Member Author

Thanks! I'll do another find and replace to make sure we got 'em all.

@bmorelli25 bmorelli25 merged commit 587d7f8 into elastic:master Sep 1, 2020
@bmorelli25 bmorelli25 deleted the logstash-out-event branch September 1, 2020 00:07
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Sep 1, 2020
# Conflicts:
#	libbeat/outputs/logstash/docs/logstash.asciidoc
bmorelli25 added a commit to bmorelli25/beats that referenced this pull request Sep 1, 2020
# Conflicts:
#	libbeat/outputs/logstash/docs/logstash.asciidoc
v1v added a commit to v1v/beats that referenced this pull request Sep 2, 2020
…ne-2.0

* upstream/master: (87 commits)
  [packaging] Normalise GCP bucket folder structure (elastic#20903)
  [Metricbeat] Add billing metricset into googlecloud module (elastic#20812)
  Include python docs in devguide index (elastic#20917)
  Avoid generating incomplete configurations in autodiscover (elastic#20898)
  Improve docs of leaderelection configuration (elastic#20601)
  Document how to set the ES host and Kibana URLs in Ingest Manager (elastic#20874)
  docs: Update beats for APM (elastic#20881)
  Adding cborbeat to community beats (elastic#20884)
  Bump kibana version to 7.9.0 in x-pack/metricbeat (elastic#20899)
  Kubernetes state_daemonset metricset for Metricbeat (elastic#20649)
  [Filebeat][zeek] Add new x509 fields to zeek (elastic#20867)
  [Filebeat][Gsuite] Add note about admin in gsuite docs (elastic#20855)
  Ensure kind cluster has RFC1123 compliant name (elastic#20627)
  Setup python paths in test runner configuration (elastic#20832)
  docs: Add  `processor.event` info to Logstash output (elastic#20721)
  docs: update cipher suites (elastic#20697)
  [ECS] Update ecs to 1.6.0 (elastic#20792)
  Fix path in hits docs (elastic#20447)
  Update filebeat azure module documentation (elastic#20815)
  Remove duplicate ListGroupsForUsers in aws/cloudtrail (elastic#20788)
  ...
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Docs Label for the Observability docs team v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: clarify output documentation
4 participants