Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][Gsuite] Add note about admin in gsuite docs #20855

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Aug 31, 2020

What does this PR do?

Adds a note about the user used for the GSuite module being required to be an administrator.

Why is it important?

This information was in Google docs that are linked in our module but was not easy to notice. Adding a clear note about it in our own docs will make for a much easier setup.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/siem (Team:SIEM)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 31, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 31, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20855 updated]

  • Start Time: 2020-09-01T13:10:24.607+0000

  • Duration: 24 min 2 sec

@@ -32,12 +32,15 @@ It is compatible with a subset of applications under the https://developers.goog
| Groups https://developers.google.com/admin-sdk/reports/v1/appendix/activity/groups[api docs] https://support.google.com/a/answer/6270454?hl=en&ref_topic=9027054[help] | Track changes to groups, group memberships and group messages. |
|===========================================================================================================================================================================================================================

[float]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I noticed this was missing when browsing the docs the other day. 😆

filebeat/docs/modules/gsuite.asciidoc Outdated Show resolved Hide resolved
@marc-gr marc-gr merged commit 3c7ca54 into elastic:master Sep 1, 2020
@marc-gr marc-gr deleted the gsuitedocs branch September 1, 2020 13:36
marc-gr added a commit to marc-gr/beats that referenced this pull request Sep 1, 2020
* Add note about admin in gsuite docs

* Make required steps a list

* Uppercase filebeat

(cherry picked from commit 3c7ca54)
@marc-gr marc-gr added the v7.10.0 label Sep 1, 2020
v1v added a commit to v1v/beats that referenced this pull request Sep 2, 2020
…ne-2.0

* upstream/master: (87 commits)
  [packaging] Normalise GCP bucket folder structure (elastic#20903)
  [Metricbeat] Add billing metricset into googlecloud module (elastic#20812)
  Include python docs in devguide index (elastic#20917)
  Avoid generating incomplete configurations in autodiscover (elastic#20898)
  Improve docs of leaderelection configuration (elastic#20601)
  Document how to set the ES host and Kibana URLs in Ingest Manager (elastic#20874)
  docs: Update beats for APM (elastic#20881)
  Adding cborbeat to community beats (elastic#20884)
  Bump kibana version to 7.9.0 in x-pack/metricbeat (elastic#20899)
  Kubernetes state_daemonset metricset for Metricbeat (elastic#20649)
  [Filebeat][zeek] Add new x509 fields to zeek (elastic#20867)
  [Filebeat][Gsuite] Add note about admin in gsuite docs (elastic#20855)
  Ensure kind cluster has RFC1123 compliant name (elastic#20627)
  Setup python paths in test runner configuration (elastic#20832)
  docs: Add  `processor.event` info to Logstash output (elastic#20721)
  docs: update cipher suites (elastic#20697)
  [ECS] Update ecs to 1.6.0 (elastic#20792)
  Fix path in hits docs (elastic#20447)
  Update filebeat azure module documentation (elastic#20815)
  Remove duplicate ListGroupsForUsers in aws/cloudtrail (elastic#20788)
  ...
marc-gr added a commit that referenced this pull request Sep 9, 2020
* Add note about admin in gsuite docs

* Make required steps a list

* Uppercase filebeat

(cherry picked from commit 3c7ca54)
melchiormoulin pushed a commit to melchiormoulin/beats that referenced this pull request Oct 14, 2020
* Add note about admin in gsuite docs

* Make required steps a list

* Uppercase filebeat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants