Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubernetes leaderelection improvements #21896

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Kubernetes leaderelection improvements #21896

merged 2 commits into from
Oct 19, 2020

Conversation

ChrsMark
Copy link
Member

What does this PR do?

  1. Creates leader lease under the same namespace of Beat is running (in case of inCluster mode). If not running inside k8s cluster then it defaults to default namespace.
  2. Changes ReleaseOnClose initialisation value to false so as to avoid errors like:
E1015 17:07:38.138511       1 leaderelection.go:296] Failed to release lock: Lease.coordination.k8s.io "metricbeat-cluster-leader" is invalid: spec.leaseDurationSeconds: Invalid value: 0: must be greater than 0

@ChrsMark
Create leader lease in same namespace with pod
0568950 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark
ReleaseOnClose to false
bb5df5d 
Signed-off-by: chrismark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark added Team:Platforms Label for the Integrations - Platforms team v7.10.0 labels Oct 16, 2020
@ChrsMark ChrsMark self-assigned this Oct 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 16, 2020
@ChrsMark ChrsMark changed the title Leaderelection improvements Kubernetes leaderelection improvements Oct 16, 2020
@jsoriano jsoriano self-requested a review October 16, 2020 10:49
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #21896 opened]

  • Start Time: 2020-10-16T10:44:47.074+0000

  • Duration: 104 min 18 sec

Test stats 🧪

Test Results
Failed 0
Passed 16345
Skipped 1347
Total 17692

@jsoriano jsoriano added needs_backport PR is waiting to be backported to other branches. v7.11.0 labels Oct 16, 2020
@ChrsMark ChrsMark mentioned this pull request Oct 19, 2020
Closed
@ChrsMark ChrsMark merged commit 9dc2f8c into elastic:master Oct 19, 2020
@ChrsMark ChrsMark mentioned this pull request Oct 19, 2020
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Oct 19, 2020
@ChrsMark
Kubernetes leaderelection improvements (elastic#21896)
1113b69 
(cherry picked from commit 9dc2f8c)
@ChrsMark ChrsMark removed the needs_backport PR is waiting to be backported to other branches. label Oct 19, 2020
@ChrsMark ChrsMark mentioned this pull request Oct 19, 2020
Merged
ChrsMark added a commit to ChrsMark/beats that referenced this pull request Oct 19, 2020
@ChrsMark
Kubernetes leaderelection improvements (elastic#21896)
ba8ea23 
(cherry picked from commit 9dc2f8c)
ChrsMark added a commit that referenced this pull request Oct 19, 2020
@ChrsMark
Kubernetes leaderelection improvements (#21896) (#21954)
3841f41 
(cherry picked from commit 9dc2f8c)
ChrsMark added a commit that referenced this pull request Oct 19, 2020
@ChrsMark
Kubernetes leaderelection improvements (#21896) (#21953)
760faa1 
(cherry picked from commit 9dc2f8c)
v1v added a commit to v1v/beats that referenced this pull request Oct 19, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-10
0c494b2 
* upstream/master: (23 commits)
  [Ingest Manager] Prevent reporting ecs version twice (elastic#21616)
  [CI] Use google storage to keep artifacts (elastic#21910)
  Update docs.asciidoc (elastic#21849)
  Kubernetes leaderelection improvements (elastic#21896)
  Apply name changes to elastic agent docs (elastic#21549)
  Add 7.7.1 relnotes to 7.8 docs (elastic#21937) (elastic#21941)
  [libbeat] Fix potential deadlock in the disk queue + add more unit tests (elastic#21930)
  Refactor docker watcher to fix flaky test and other small issues (elastic#21851)
  [CI] Add stage name in the step (elastic#21887)
  [docs] Remove extra word in autodiscover docs (elastic#21871)
  [CI] lint stage doesn't produce test reports (elastic#21888)
  Add tests of reader of filestream input (elastic#21814)
  [Ingest Manager] Use local temp instead of system one (elastic#21883)
  chore: delegate variant pushes to the right method (elastic#21861)
  [CI] kind setup fails sometimes (elastic#21857)
  Fix panic on add_docker_metadata close (elastic#21882)
  Add tests for fileProspector in filestream input (elastic#21712)
  [Filebeat][okta] Fix okta pagination (elastic#21797)
  Add cloud.account.id into add_cloud_metadata for gcp (elastic#21776)
  Fix syslog RFC 5424 parsing in CheckPoint module (elastic#21854)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 19, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/windows-2008
40f297d 
* upstream/master: (23 commits)
  [Ingest Manager] Prevent reporting ecs version twice (elastic#21616)
  [CI] Use google storage to keep artifacts (elastic#21910)
  Update docs.asciidoc (elastic#21849)
  Kubernetes leaderelection improvements (elastic#21896)
  Apply name changes to elastic agent docs (elastic#21549)
  Add 7.7.1 relnotes to 7.8 docs (elastic#21937) (elastic#21941)
  [libbeat] Fix potential deadlock in the disk queue + add more unit tests (elastic#21930)
  Refactor docker watcher to fix flaky test and other small issues (elastic#21851)
  [CI] Add stage name in the step (elastic#21887)
  [docs] Remove extra word in autodiscover docs (elastic#21871)
  [CI] lint stage doesn't produce test reports (elastic#21888)
  Add tests of reader of filestream input (elastic#21814)
  [Ingest Manager] Use local temp instead of system one (elastic#21883)
  chore: delegate variant pushes to the right method (elastic#21861)
  [CI] kind setup fails sometimes (elastic#21857)
  Fix panic on add_docker_metadata close (elastic#21882)
  Add tests for fileProspector in filestream input (elastic#21712)
  [Filebeat][okta] Fix okta pagination (elastic#21797)
  Add cloud.account.id into add_cloud_metadata for gcp (elastic#21776)
  Fix syslog RFC 5424 parsing in CheckPoint module (elastic#21854)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 19, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-f…
4039f89 
…laky-test-analyser

* upstream/master: (22 commits)
  [Ingest Manager] Prevent reporting ecs version twice (elastic#21616)
  [CI] Use google storage to keep artifacts (elastic#21910)
  Update docs.asciidoc (elastic#21849)
  Kubernetes leaderelection improvements (elastic#21896)
  Apply name changes to elastic agent docs (elastic#21549)
  Add 7.7.1 relnotes to 7.8 docs (elastic#21937) (elastic#21941)
  [libbeat] Fix potential deadlock in the disk queue + add more unit tests (elastic#21930)
  Refactor docker watcher to fix flaky test and other small issues (elastic#21851)
  [CI] Add stage name in the step (elastic#21887)
  [docs] Remove extra word in autodiscover docs (elastic#21871)
  [CI] lint stage doesn't produce test reports (elastic#21888)
  Add tests of reader of filestream input (elastic#21814)
  [Ingest Manager] Use local temp instead of system one (elastic#21883)
  chore: delegate variant pushes to the right method (elastic#21861)
  [CI] kind setup fails sometimes (elastic#21857)
  Fix panic on add_docker_metadata close (elastic#21882)
  Add tests for fileProspector in filestream input (elastic#21712)
  [Filebeat][okta] Fix okta pagination (elastic#21797)
  Add cloud.account.id into add_cloud_metadata for gcp (elastic#21776)
  Fix syslog RFC 5424 parsing in CheckPoint module (elastic#21854)
  ...
v1v added a commit to v1v/beats that referenced this pull request Oct 20, 2020
@v1v
Merge remote-tracking branch 'upstream/master' into feature/packaging…
21cd8fa 
…-store-in-another-location-too

* upstream/master:
  [Ingest Manager] Prevent reporting ecs version twice (elastic#21616)
  [CI] Use google storage to keep artifacts (elastic#21910)
  Update docs.asciidoc (elastic#21849)
  Kubernetes leaderelection improvements (elastic#21896)
  Apply name changes to elastic agent docs (elastic#21549)
  Add 7.7.1 relnotes to 7.8 docs (elastic#21937) (elastic#21941)
  [libbeat] Fix potential deadlock in the disk queue + add more unit tests (elastic#21930)
  Refactor docker watcher to fix flaky test and other small issues (elastic#21851)
  [CI] Add stage name in the step (elastic#21887)
  [docs] Remove extra word in autodiscover docs (elastic#21871)
  [CI] lint stage doesn't produce test reports (elastic#21888)
  Add tests of reader of filestream input (elastic#21814)
  [Ingest Manager] Use local temp instead of system one (elastic#21883)
This was referenced Dec 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@ChrsMark ChrsMark

Labels
Team:Platforms Label for the Integrations - Platforms team v7.10.0 v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrsMark @elasticmachine @jsoriano