-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s client and release k8s lock gracefully #22919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismark <chrismarkou92@gmail.com>
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 4, 2020
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Dec 4, 2020
Signed-off-by: chrismark <chrismarkou92@gmail.com>
Collaborator
jsoriano
added
needs_backport
PR is waiting to be backported to other branches.
test-plan
Add this PR to be manual test plan
v7.11.0
labels
Dec 7, 2020
jsoriano
approved these changes
Dec 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ChrsMark for keeping an eye on this!
ChrsMark
added a commit
to ChrsMark/beats
that referenced
this pull request
Dec 9, 2020
(cherry picked from commit deba318)
ChrsMark
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Dec 9, 2020
ChrsMark
added a commit
that referenced
this pull request
Dec 9, 2020
This was referenced Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team:Platforms
Label for the Integrations - Platforms team
test-plan
Add this PR to be manual test plan
test-plan-added
This PR has been added to the test plan
v7.11.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates k8s go client to utilise a fix so as to gracefully release leader lock.
Why is it important?
To release the leader lease gracefully and make it instantly available for other candidates.
Related issues
How to test this PR locally
kind create cluster --config kind-mutly.yaml
metricbeat-kubernetes-leader.7.11.yaml.txt
Follow the logs of the 2 daemonset pods and kill the one holding the lease. Verify that no errors occur and that the lease was gained by the other Pod.
Verify that basic autodiscovery works along with metadata:
nats.yaml.txt