Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat][okta] Make cursor optional for okta and update docs #22091

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 22, 2020

What does this PR do?

  • Update docs to reflect new behaviour after adding the cursor to the module.

Why is it important?

Previously Okta module pulled up to 7 days of logs every time, which was unconvenient when someone had big amounts of them. This is not the case anymore, and we document it accordingly.

cc @jamiehynds

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 22, 2020
@marc-gr marc-gr requested a review from a team October 22, 2020 13:32
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 22, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22091 updated]

  • Start Time: 2020-10-27T09:18:08.965+0000

  • Duration: 23 min 54 sec

@marc-gr marc-gr merged commit d671e52 into elastic:master Oct 27, 2020
@marc-gr marc-gr deleted the okta-optional-cursor branch October 27, 2020 11:28
marc-gr added a commit to marc-gr/beats that referenced this pull request Oct 27, 2020
…ic#22091)

* Make cursor optional for okta and update docs

* Remove keep_state flag

(cherry picked from commit d671e52)
v1v added a commit to v1v/beats that referenced this pull request Oct 27, 2020
…laky-test-analyser

* upstream/master:
  Add new licence status: expired (elastic#22180)
  [filebeat][okta] Make cursor optional for okta and update docs (elastic#22091)
  Add documentation of filestream input (elastic#21615)
  [Ingest Manager] Skip flaky gateway tests elastic#22177
  [CI] set env variable for the params (elastic#22143)
  Fix zeek connection pipeline (elastic#22151)
  Fix Google Cloud Function configuration file issues (elastic#22156)
  Remove old TODO on kubernetes node update (elastic#22074)
v1v added a commit to v1v/beats that referenced this pull request Oct 27, 2020
…ter-commit

* upstream/master:
  Add new licence status: expired (elastic#22180)
  [filebeat][okta] Make cursor optional for okta and update docs (elastic#22091)
  Add documentation of filestream input (elastic#21615)
  [Ingest Manager] Skip flaky gateway tests elastic#22177
v1v added a commit to v1v/beats that referenced this pull request Oct 27, 2020
…laky-test-analyser

* upstream/master:
  Add new licence status: expired (elastic#22180)
  [filebeat][okta] Make cursor optional for okta and update docs (elastic#22091)
  Add documentation of filestream input (elastic#21615)
  [Ingest Manager] Skip flaky gateway tests elastic#22177
  [CI] set env variable for the params (elastic#22143)
  Fix zeek connection pipeline (elastic#22151)
  Fix Google Cloud Function configuration file issues (elastic#22156)
  Remove old TODO on kubernetes node update (elastic#22074)
marc-gr added a commit to marc-gr/beats that referenced this pull request Oct 27, 2020
…ic#22091)

* Make cursor optional for okta and update docs

* Remove keep_state flag

(cherry picked from commit d671e52)
marc-gr added a commit that referenced this pull request Oct 27, 2020
… (#22181)

* Make cursor optional for okta and update docs

* Remove keep_state flag

(cherry picked from commit d671e52)
marc-gr added a commit that referenced this pull request Oct 27, 2020
… (#22182)

* Make cursor optional for okta and update docs

* Remove keep_state flag

(cherry picked from commit d671e52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants