Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22091 to 7.10: [filebeat][okta] Make cursor optional for okta and update docs #22182

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Oct 27, 2020

Cherry-pick of PR #22091 to 7.10 branch. Original message:

What does this PR do?

  • Update docs to reflect new behaviour after adding the cursor to the module.

Why is it important?

Previously Okta module pulled up to 7 days of logs every time, which was unconvenient when someone had big amounts of them. This is not the case anymore, and we document it accordingly.

cc @jamiehynds

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 27, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 27, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22182 updated]

  • Start Time: 2020-10-27T16:26:13.884+0000

  • Duration: 25 min 54 sec

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
…ic#22091)

* Make cursor optional for okta and update docs

* Remove keep_state flag

(cherry picked from commit d671e52)
@marc-gr marc-gr merged commit 385b22d into elastic:7.10 Oct 27, 2020
@marc-gr marc-gr deleted the backport_22091_7.10 branch October 27, 2020 16:52
@zube zube bot removed the [zube]: Done label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants