Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metricbeat] Rename googlecloud module to gcp module in Metricbeat #22246

Merged
merged 6 commits into from
Nov 3, 2020
Merged

[Metricbeat] Rename googlecloud module to gcp module in Metricbeat #22246

merged 6 commits into from
Nov 3, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Oct 28, 2020 •
edited
Loading

What does this PR do?

This PR is to rename googlecloud module in Metricbeat to gcp module. Since this module is still in beta, I'm making this a breaking change to rename the module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Test compute metricset by enabling gcp module first with ./metricbeat modules enable gcp and then edit modules.d/gcp.yml with:

- module: gcp
  metricsets:
    - compute
  region: "us-"
  project_id: "elastic-observability"
  credentials_file_path: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"
  exclude_labels: false
  period: 1m

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2020
@kaiyan-sheng kaiyan-sheng self-assigned this Oct 28, 2020
@kaiyan-sheng kaiyan-sheng added the Team:Platforms Label for the Integrations - Platforms team label Oct 28, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2020
@kaiyan-sheng kaiyan-sheng added in progress Pull request is currently in progress. needs_team Indicates that the issue/PR needs a Team:* label labels Oct 28, 2020
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 28, 2020
@botelastic
Copy link

botelastic bot commented Oct 28, 2020

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng mentioned this pull request Oct 28, 2020
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 28, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22246 updated]

  • Start Time: 2020-11-03T12:24:21.815+0000

  • Duration: 79 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2761
Skipped 613
Total 3374

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2761
Skipped 613
Total 3374

ChrsMark
ChrsMark approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any problem with this. Just one question: Is it a breaking change and do we have a clear path about the version of this change? Could it be added in the PR description for reference so as to point users asking about this in the future?

@kaiyan-sheng
Copy link
Contributor Author

@ChrsMark Thanks for the review. Yeah this is a breaking change and I'm thinking to put it in 7.11 because googlecloud/gcp module is still in beta. Once the decision of making this a breaking change is done, I will update the description. Thank you!!

@kaiyan-sheng
Copy link
Contributor Author

@ChrsMark We are good on making this a breaking change since this module is still in beta. I also updated the PR description.

@dedemorton dedemorton mentioned this pull request Nov 3, 2020
Merged
@kaiyan-sheng kaiyan-sheng removed the in progress Pull request is currently in progress. label Nov 3, 2020
@kaiyan-sheng kaiyan-sheng merged commit 7fb60fc into elastic:master Nov 3, 2020
@kaiyan-sheng kaiyan-sheng deleted the gcp_mb_rename branch November 3, 2020 20:17
@kaiyan-sheng kaiyan-sheng mentioned this pull request Nov 3, 2020
Merged
6 tasks
kaiyan-sheng added a commit that referenced this pull request Nov 4, 2020
@kaiyan-sheng
Cherry-pick #22246 to 7.x: [Metricbeat] Rename googlecloud module to …
542d094 
…gcp module in Metricbeat (#22405)

* [Metricbeat] Rename googlecloud module to gcp module in Metricbeat (#22246)

(cherry picked from commit 7fb60fc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Platforms Label for the Integrations - Platforms team v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @ChrsMark