Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #22246 to 7.x: [Metricbeat] Rename googlecloud module to gcp module in Metricbeat #22405

Merged
merged 2 commits into from
Nov 4, 2020
Merged

Cherry-pick #22246 to 7.x: [Metricbeat] Rename googlecloud module to gcp module in Metricbeat #22405

merged 2 commits into from
Nov 4, 2020

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Nov 3, 2020

Cherry-pick of PR #22246 to 7.x branch. Original message:

What does this PR do?

This PR is to rename googlecloud module in Metricbeat to gcp module. Since this module is still in beta, I'm making this a breaking change to rename the module.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Test compute metricset by enabling gcp module first with ./metricbeat modules enable gcp and then edit modules.d/gcp.yml with:

- module: gcp
  metricsets:
    - compute
  region: "us-"
  project_id: "elastic-observability"
  credentials_file_path: "/Users/kaiyansheng/Desktop/elastic-observability-5537b831234a.json"
  exclude_labels: false
  period: 1m

Related issues

@kaiyan-sheng kaiyan-sheng added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 3, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 3, 2020
@botelastic
Copy link

botelastic bot commented Nov 3, 2020

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng self-assigned this Nov 3, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 3, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22405 updated]

  • Start Time: 2020-11-03T21:43:51.009+0000

  • Duration: 77 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 2757
Skipped 614
Total 3371

@elasticmachine
Copy link
Collaborator

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2757
Skipped 614
Total 3371

@kaiyan-sheng kaiyan-sheng merged commit 542d094 into elastic:7.x Nov 4, 2020
@kaiyan-sheng kaiyan-sheng deleted the backport_22246_7.x branch November 4, 2020 14:16
@zube zube bot removed the [zube]: Done label Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants