Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Agent fetching DBus service PID fix #23496

Merged
merged 4 commits into from
Jan 15, 2021

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

For some reason debian9 is not happy when quering service without .service suffix just by a service name.
Adding that debian does not complain anymore

Why is it important?

This prevents us from monitoring PID and checking agent crashes. If agent crashes constantly status checker will know and rollback instead of this crash checker, so i would not say it's that critical.

Fixes: #23488

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 14, 2021
@michalpristas
Copy link
Contributor Author

cc @EricDavisX

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23496 updated

    • Start Time: 2021-01-15T09:04:22.318+0000
  • Duration: 18 min 52 sec

  • Commit: 2f91bc9

Test stats 🧪

Test Results
Failed 0
Passed 1426
Skipped 4
Total 1430

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1426
Skipped 4
Total 1430

@EricDavisX
Copy link
Contributor

thx - are we intending backports for 7.11? up to you.

@michalpristas
Copy link
Contributor Author

yes i wanted to backport this one

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh debian.... Looks good!

@michalpristas michalpristas merged commit 8d2c723 into elastic:master Jan 15, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Jan 15, 2021
[Ingest Manager] Agent fetching DBus service PID fix (elastic#23496)
michalpristas added a commit to michalpristas/beats that referenced this pull request Jan 15, 2021
[Ingest Manager] Agent fetching DBus service PID fix (elastic#23496)
michalpristas added a commit that referenced this pull request Jan 17, 2021
* [Ingest Manager] Agent fetching DBus service PID fix (#23496)

[Ingest Manager] Agent fetching DBus service PID fix (#23496)

* Update CHANGELOG.next.asciidoc
michalpristas added a commit that referenced this pull request Jan 17, 2021
* [Ingest Manager] Agent fetching DBus service PID fix (#23496)

[Ingest Manager] Agent fetching DBus service PID fix (#23496)

* Update CHANGELOG.next.asciidoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Team:Elastic-Agent Label for the Agent team v7.11.0
Projects
None yet
4 participants