Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #23496 to 7.x: Agent fetching DBus service PID fix #23525

Merged
merged 3 commits into from
Jan 17, 2021

Conversation

michalpristas
Copy link
Contributor

Cherry-pick of PR #23496 to 7.x branch. Original message:

What does this PR do?

For some reason debian9 is not happy when quering service without .service suffix just by a service name.
Adding that debian does not complain anymore

Why is it important?

This prevents us from monitoring PID and checking agent crashes. If agent crashes constantly status checker will know and rollback instead of this crash checker, so i would not say it's that critical.

Fixes: #23488

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

[Ingest Manager] Agent fetching DBus service PID fix (elastic#23496)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 15, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23525 updated

    • Start Time: 2021-01-17T13:32:13.357+0000
  • Duration: 20 min 12 sec

  • Commit: b7f427c

Test stats 🧪

Test Results
Failed 0
Passed 1414
Skipped 6
Total 1420

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1414
Skipped 6
Total 1420

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good.

@michalpristas michalpristas merged commit 1f24f1a into elastic:7.x Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants