Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty configuration options generate <no value> string for azure-eventhub input #24156

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Empty configuration options generate <no value> string for azure-eventhub input #24156

merged 2 commits into from
Feb 23, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 22, 2021

What does this PR do?

makes sure to provide empty string values when input configuration is validated

Why is it important?

<no value> string is sent instead of empty value and sometimes passes required validation

Checklist

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 22, 2021
@narph narph self-assigned this Feb 22, 2021
@narph narph added the Team:Integrations Label for the Integrations team label Feb 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 22, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 22, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24156 updated

  • Start Time: 2021-02-22T13:59:23.607+0000

  • Duration: 47 min 42 sec

  • Commit: 2a86130

Test stats 🧪

Test Results
Failed 0
Passed 6840
Skipped 1153
Total 7993

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6840
Skipped 1153
Total 7993

@andresrc
Copy link
Contributor

do we need to make (some of) these changes in the package as well?

adriansr
adriansr approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adriansr adriansr added bug needs_backport PR is waiting to be backported to other branches. labels Feb 23, 2021
@narph narph merged commit 916d4e0 into elastic:master Feb 23, 2021
@narph narph deleted the az-err branch February 23, 2021 11:50
@narph
Copy link
Contributor Author

narph commented Feb 23, 2021 •
edited
Loading

@andresrc

do we need to make (some of) these changes in the package as well?

different behavior is found there but we should add the same check for the params as well, will follow up with a PR

@narph narph mentioned this pull request Feb 23, 2021
Merged
@narph narph added v7.13.0 and removed needs_backport PR is waiting to be backported to other branches. labels Feb 23, 2021
narph added a commit to narph/beats that referenced this pull request Feb 23, 2021
@narph
Empty configuration options generate <no value> string for azure-ev…
ebf9c75 
…enthub input (elastic#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)
@narph narph mentioned this pull request Feb 23, 2021
Merged
@narph narph added the v7.11.2 label Feb 23, 2021
narph added a commit to narph/beats that referenced this pull request Feb 23, 2021
@narph
Empty configuration options generate <no value> string for azure-ev…
d5d4d29 
…enthub input (elastic#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)
@narph narph mentioned this pull request Feb 23, 2021
Merged
@narph narph added the v7.12.0 label Feb 23, 2021
narph added a commit to narph/beats that referenced this pull request Feb 23, 2021
@narph
Empty configuration options generate <no value> string for azure-ev…
c163eae 
…enthub input (elastic#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)
v1v added a commit to v1v/beats that referenced this pull request Feb 23, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/packaging…
2e57ac2 
…-arm

* upstream/master: (24 commits)
  Add example input autodsicover config (elastic#24157)
  Empty configuration options generate `<no value>` string for azure-eventhub input (elastic#24156)
  Remove OSS reference for kibana and elasticsearch (elastic#24164)
  Skip flaky TestActions on MacOSx (elastic#23966)
  [Filebeat][AWS] Fix vpcflow pipeline exception: Cannot invoke "Object.getClass()" because "receiver" is null (elastic#24167)
  [Elastic Agent] Fix docker entrypoint for elastic-agent. (elastic#24155)
  [PACKAGING] Push docker images with the architecture in the version (elastic#24121)
  [Agent] Add agent standalone manifests for system module & Pod's log collection (elastic#23938)
  indicator type url is in upper case (elastic#24152)
  [Filebeat] Document netflow internal_networks and set default (elastic#24110)
  [Filebeat] Adding fixes to the TI module (elastic#24133)
  [Enhancement] Add RotateOnStartup feature flag for file output (elastic#19347)
  [Ingest Manager] Fix: Successfully installed and enrolled agent running standalone (elastic#24128)
  Set Elastic licence type for APM server Beats update job (elastic#24122)
  Add logrotation section on Running Filebeat on k8s (elastic#24120)
  [CI] Run if manual UI (elastic#24116)
  [CI] enable x-pack/heartbeat in the CI (elastic#23873)
  chore: comment out the E2E (elastic#24109)
  chore: add-backport-next (elastic#24098)
  Adjust the position of the architecture name in Dockerlogbeat tarball (elastic#24095)
  ...
narph added a commit that referenced this pull request Feb 23, 2021
@narph
Cherry-pick #24156 to 7.12: Empty configuration options generate `<no…
54c0584 
… value>` string for azure-eventhub input (#24183)

* Empty configuration options generate `<no value>` string for azure-eventhub input (#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)

* fix changelog
v1v added a commit to v1v/beats that referenced this pull request Feb 23, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/retry-win…
965d5e9 
…dows-7

* upstream/master:
  [CI] Add ARM packaging (elastic#24041)
  Add example input autodsicover config (elastic#24157)
  Empty configuration options generate `<no value>` string for azure-eventhub input (elastic#24156)
narph added a commit that referenced this pull request Mar 10, 2021
@narph
Cherry-pick #24156 to 7.x: Empty configuration options generate `<no …
bea9a9b 
…value>` string for azure-eventhub input (#24181)

* Empty configuration options generate `<no value>` string for azure-eventhub input (#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)

* fix changelog
narph added a commit that referenced this pull request Mar 10, 2021
@narph
Cherry-pick #24156 to 7.11: Empty configuration options generate `<no…
c46cc27 
… value>` string for azure-eventhub input (#24182)

* Empty configuration options generate `<no value>` string for azure-eventhub input (#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)

* fix changelog

* fix changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

Assignees

@narph narph

Labels
bug Team:Integrations Label for the Integrations team v7.11.2 v7.12.0 v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narph @elasticmachine @andresrc @adriansr