Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #24156 to 7.12: Empty configuration options generate <no value> string for azure-eventhub input #24183

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Cherry-pick #24156 to 7.12: Empty configuration options generate <no value> string for azure-eventhub input #24183

merged 2 commits into from
Feb 23, 2021

Conversation

narph
Copy link
Contributor

@narph narph commented Feb 23, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24156 to 7.12 branch. Original message:

What does this PR do?

makes sure to provide empty string values when input configuration is validated

Why is it important?

<no value> string is sent instead of empty value and sometimes passes required validation

Checklist

@narph
Empty configuration options generate <no value> string for azure-ev…
c163eae 
…enthub input (elastic#24156)

* work on no value

* changelog

(cherry picked from commit 916d4e0)
@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Feb 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 23, 2021
@narph narph self-assigned this Feb 23, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24183 updated

  • Start Time: 2021-02-23T12:31:20.040+0000

  • Duration: 47 min 15 sec

  • Commit: 27f02f7

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6814
Skipped 1153
Total 7967

@narph narph merged commit 54c0584 into elastic:7.12 Feb 23, 2021
@narph narph deleted the backport_24156_7.12 branch February 23, 2021 15:22
@zube zube bot removed the [zube]: Done label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels
backport Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narph @elasticmachine @ChrsMark