Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links to Beats product pages #24821

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Conversation

dedemorton
Copy link
Contributor

@dedemorton dedemorton commented Mar 29, 2021

What does this PR do?

Updates base URL used for links to the Beats product pages.

Why is it important?

Relying on the redirects is problematic because they can cause issues with SEO if there are multiple redirects in place.

Checklist

  • My code follows the style guidelines of this project

Related issues

@dedemorton dedemorton requested a review from a team March 29, 2021 18:15
@dedemorton dedemorton self-assigned this Mar 29, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 29, 2021
@jsoriano jsoriano added the Team:Docs Label for the Observability docs team label Mar 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 29, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24821 updated

  • Start Time: 2021-04-05T21:50:08.832+0000

  • Duration: 131 min 25 sec

  • Commit: 611c6f2

Test stats 🧪

Test Results
Failed 0
Passed 46544
Skipped 5132
Total 51676

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46544
Skipped 5132
Total 51676

@dedemorton
Copy link
Contributor Author

jenkins run the tests please

2 similar comments
@dedemorton
Copy link
Contributor Author

jenkins run the tests please

@dedemorton
Copy link
Contributor Author

jenkins run the tests please

@dedemorton
Copy link
Contributor Author

jenkins run the tests please

@dedemorton
Copy link
Contributor Author

^ trying to get a clean build. I've been trying for over a week. Very frustrating.

@dedemorton dedemorton merged commit 6981ca3 into elastic:master Apr 6, 2021
@dedemorton dedemorton deleted the issue#24776 branch April 6, 2021 20:08
@dedemorton dedemorton added v7.13.0 and removed v7.12.0 labels Apr 6, 2021
dedemorton added a commit to dedemorton/beats that referenced this pull request Apr 6, 2021
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Docs Label for the Observability docs team v7.13.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beats docs have a broken link to packetbeat on 'what are beats' overview page
4 participants