Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Add check for URL set when cert and cert key. #24904

Merged
merged 3 commits into from
Apr 5, 2021
Merged

[Elastic Agent] Add check for URL set when cert and cert key. #24904

merged 3 commits into from
Apr 5, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Apr 1, 2021 •
edited
Loading

What does this PR do?

Adds a check to ensure that --url is provided when --fleet-server-cert and --fleet-server-cert-key is provided.

Why is it important?

So its clear that when those 2 parameters are provided that a communicate URL --url must also be provided.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added the Team:Elastic-Agent Label for the Agent team label Apr 1, 2021
@blakerouse blakerouse self-assigned this Apr 1, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 1, 2021
@blakerouse blakerouse marked this pull request as ready for review April 1, 2021 14:31
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 1, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: blakerouse commented: /test

  • Start Time: 2021-04-01T19:31:19.769+0000

  • Duration: 48 min 2 sec

  • Commit: 26157b4

Test stats 🧪

Test Results
Failed 0
Passed 6612
Skipped 16
Total 6628

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6612
Skipped 16
Total 6628

@blakerouse
Copy link
Contributor Author

/test

@blakerouse blakerouse merged commit 5e5e407 into elastic:master Apr 5, 2021
@blakerouse blakerouse deleted the fix-24893 branch April 5, 2021 13:03
@blakerouse blakerouse mentioned this pull request Apr 5, 2021
Merged
3 tasks
blakerouse added a commit to blakerouse/beats that referenced this pull request Apr 5, 2021
@blakerouse
[Elastic Agent] Add check for URL set when cert and cert key. (elasti…
1cdd07f 
…c#24904)

* Add check for URL set when cert and cert key.

* Add changelog.

(cherry picked from commit 5e5e407)
blakerouse added a commit that referenced this pull request Apr 5, 2021
@blakerouse
[Elastic Agent] Add check for URL set when cert and cert key. (#24904) (
0f1c4e4 
#24932)

* Add check for URL set when cert and cert key.

* Add changelog.

(cherry picked from commit 5e5e407)
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Apr 7, 2021
@blakerouse @michalpristas
[Elastic Agent] Add check for URL set when cert and cert key. (elasti…
556dc82 
…c#24904)

* Add check for URL set when cert and cert key.

* Add changelog.
v1v added a commit to v1v/beats that referenced this pull request Apr 7, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/mergify
c1238b8 
* upstream/master: (91 commits)
  [Filebeat] Change okta.target to nested field (elastic#24636)
  Add RFC5424 format support for syslog input  (elastic#23954)
  Fix links to Beats product pages (elastic#24821)
  [DOCS] Fix 'make setup' instructions for a new beat (elastic#24944)
  Remove duplicate decode_xml entry (elastic#24941)
  [libbeat] Add wineventlog schema to decode_xml processor (elastic#24726)
  [Elastic Agent] Add check for URL set when cert and cert key. (elastic#24904)
  feat: stage execution cache (elastic#24780)
  Fix error in Journalbeat commands (elastic#24880)
  Add baseline ECS 1.9.0 upgrade (elastic#24909)
  [Elastic Agent] Cloud container legacy apm files. (elastic#24896)
  [Elastic Agent]: Reduce allowed socket path length (elastic#24914)
  Add ability to destroy indices with wildcards in testing (elastic#24915)
  Add status subcommand to report status of running daemon. (elastic#24856)
  Fix types of fields GetHits and Ops in Metricbeat module for Couchbase (elastic#23287)
  Add support for Filestream input in elastic agent. (elastic#24820)
  Implement k8s secrets provider for Agent (elastic#24789)
  Sort processor list in docs (elastic#24874)
  Add support for SCRAM authentication in kafka metricbeat module (elastic#24810)
  Properly update offset in case of unparasable line (elastic#22685)
  ...
@simitt simitt mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees

@blakerouse blakerouse

Labels
Team:Elastic-Agent Label for the Agent team v7.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Elastic-Agent] Enrollment URI to Fleet Server is empty when certificate is provided
3 participants
@blakerouse @elasticmachine @simitt