Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated filter expression for filtering 86 artifacts #26313

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Updated filter expression for filtering 86 artifacts #26313

merged 5 commits into from
Jun 15, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jun 15, 2021 •
edited by ph
Loading

What does this PR do?

Avoids overwriting Platforms expression in init of agent magefile.

Why is it important?

Make build work correctly

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Ref: #26239

@michalpristas michalpristas added bug needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team labels Jun 15, 2021
@michalpristas michalpristas self-assigned this Jun 15, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 15, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 15, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26313 updated

  • Start Time: 2021-06-15T18:59:47.667+0000

  • Duration: 75 min 11 sec

  • Commit: 3d3bc43

Test stats 🧪

Test Results
Failed 0
Passed 6908
Skipped 16
Total 6924

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6908
Skipped 16
Total 6924

@michalpristas
Copy link
Contributor Author

/package

@michalpristas michalpristas requested a review from ph June 15, 2021 10:50
@michalpristas michalpristas marked this pull request as ready for review June 15, 2021 10:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@michalpristas michalpristas requested a review from a team as a code owner June 15, 2021 10:56
@botelastic botelastic bot added the Team:Automation Label for the Observability productivity team label Jun 15, 2021
@michalpristas @v1v
Update x-pack/elastic-agent/magefile.go
8228e71 
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@michalpristas
Copy link
Contributor Author

/package

@michalpristas
Copy link
Contributor Author

/package

blakerouse
blakerouse approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at this as well, I had setup an ARM machine in AWS to test on. This fixes the issue for me.

@ph
Copy link
Contributor

ph commented Jun 15, 2021

I've build it locally this fixes the problem for me too.

@michalpristas michalpristas merged commit 5cfdbe7 into elastic:master Jun 15, 2021
michalpristas added a commit that referenced this pull request Jun 15, 2021
@michalpristas
Updated filter expression for filtering 86 artifacts (#26313)
3216164 
Updated filter expression for filtering 86 artifacts (#26313)
michalpristas added a commit to michalpristas/beats that referenced this pull request Jun 17, 2021
@michalpristas
Updated filter expression for filtering 86 artifacts (elastic#26313)
5c5e7d8 
Updated filter expression for filtering 86 artifacts (elastic#26313)
@michalpristas michalpristas mentioned this pull request Jun 17, 2021
Closed
@v1v v1v mentioned this pull request Jun 21, 2021
Merged
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
ead2f67 
* master: (25 commits)
  Fix UBI source URL (elastic#26384)
  Skip test_rotating_file in osx and windows (elastic#26379)
  Remove outdated k8s manifests for managed elastic-agent (elastic#26368)
  Enable agent to send custom headers to kibana/ES (elastic#26275)
  [Automation] Update elastic stack version to 8.0.0-943ef2c0 for testing (elastic#26354)
  Make the Syslog input GA (elastic#26293)
  Move Kerberos FAST config flag to shared kerberos config (elastic#26141)
  Add k8s cluster identifiers (elastic#26056)
  Store message from MongoDB json logs in message field (elastic#26338)
  update threatintel ECS version (elastic#26274)
  update envoyproxy ECS version (elastic#26277)
  [Filebeat] [MongoDB] Support MongoDB 4.4 json logs (elastic#24774)
  Update go-structform to 0.0.9 (elastic#26251)
  Forward port 7.13.2 changelog to master (elastic#26323)
  Updated filter expression for filtering 86 artifacts (elastic#26313)
  Osquerybeat: Align with the rest of the beats, set the ECS version (elastic#26324)
  [Packetbeat] Add `url.extension` to Packetbeat HTTP events (elastic#25999)
  Change link to snapshots in README (elastic#26317)
  Don't include full ES index template in errors (elastic#25743)
  First refactor of the system module - system/cpu and system/core (elastic#25771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v left review comments

@blakerouse blakerouse blakerouse approved these changes

@ph ph ph approved these changes

Assignees

@michalpristas michalpristas

Labels
bug needs_backport PR is waiting to be backported to other branches. Team:Automation Label for the Observability productivity team Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalpristas @elasticmachine @ph @v1v @blakerouse