Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Osquerybeat: Align with the rest of the beats, set the ECS version #26324

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Osquerybeat: Align with the rest of the beats, set the ECS version #26324

merged 1 commit into from
Jun 15, 2021

Conversation

aleksmaus
Copy link
Member

What does this PR do?

Align with the rest of the beats with setting the ECS version.
This was missing and noticed by @P1llus.

Why is it important?

Follows the beats ECS recommendation

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas

Screenshots

Screen Shot 2021-06-15 at 9 16 46 AM

@aleksmaus aleksmaus added cleanup backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify Team:Asset Mgt labels Jun 15, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 15, 2021
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26324 opened

  • Start Time: 2021-06-15T16:17:49.554+0000

  • Duration: 66 min 56 sec

  • Commit: 2113857

Test stats 🧪

Test Results
Failed 0
Passed 128
Skipped 0
Total 128

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 128
Skipped 0
Total 128

scunningham
scunningham approved these changes Jun 15, 2021
View reviewed changes
Copy link

@scunningham scunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic.

@james-elastic
Copy link

🧇 👍

@aleksmaus aleksmaus merged commit 8c810f9 into elastic:master Jun 15, 2021
mergify bot pushed a commit that referenced this pull request Jun 15, 2021
@aleksmaus
Osquerybeat: Align with the rest of the beats, set the ECS version (#…
a8de0d0 
…26324)

(cherry picked from commit 8c810f9)
@mergify mergify bot mentioned this pull request Jun 15, 2021
Merged
mergify bot pushed a commit that referenced this pull request Jun 15, 2021
@aleksmaus
Osquerybeat: Align with the rest of the beats, set the ECS version (#…
9ec1863 
…26324)

(cherry picked from commit 8c810f9)

# Conflicts:
#	x-pack/osquerybeat/cmd/root.go
@mergify mergify bot mentioned this pull request Jun 15, 2021
Closed
aleksmaus added a commit that referenced this pull request Jun 15, 2021
@mergify @aleksmaus
Osquerybeat: Align with the rest of the beats, set the ECS version (#…
e244d44 
…26324) (#26332)

(cherry picked from commit 8c810f9)

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
@P1llus P1llus mentioned this pull request Jun 16, 2021
Closed
michalpristas pushed a commit to michalpristas/beats that referenced this pull request Jun 17, 2021
@aleksmaus @michalpristas
Osquerybeat: Align with the rest of the beats, set the ECS version (e…
e5e74e3 
…lastic#26324)
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
ead2f67 
* master: (25 commits)
  Fix UBI source URL (elastic#26384)
  Skip test_rotating_file in osx and windows (elastic#26379)
  Remove outdated k8s manifests for managed elastic-agent (elastic#26368)
  Enable agent to send custom headers to kibana/ES (elastic#26275)
  [Automation] Update elastic stack version to 8.0.0-943ef2c0 for testing (elastic#26354)
  Make the Syslog input GA (elastic#26293)
  Move Kerberos FAST config flag to shared kerberos config (elastic#26141)
  Add k8s cluster identifiers (elastic#26056)
  Store message from MongoDB json logs in message field (elastic#26338)
  update threatintel ECS version (elastic#26274)
  update envoyproxy ECS version (elastic#26277)
  [Filebeat] [MongoDB] Support MongoDB 4.4 json logs (elastic#24774)
  Update go-structform to 0.0.9 (elastic#26251)
  Forward port 7.13.2 changelog to master (elastic#26323)
  Updated filter expression for filtering 86 artifacts (elastic#26313)
  Osquerybeat: Align with the rest of the beats, set the ECS version (elastic#26324)
  [Packetbeat] Add `url.extension` to Packetbeat HTTP events (elastic#25999)
  Change link to snapshots in README (elastic#26317)
  Don't include full ES index template in errors (elastic#25743)
  First refactor of the system module - system/cpu and system/core (elastic#25771)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-elastic james-elastic james-elastic approved these changes

@scunningham scunningham scunningham approved these changes

@urso urso Awaiting requested review from urso

@blakerouse blakerouse Awaiting requested review from blakerouse

@P1llus P1llus Awaiting requested review from P1llus

Assignees
No one assigned
Labels
backport-v7.13.0 Automated backport with mergify backport-v7.14.0 Automated backport with mergify cleanup Team:Asset Mgt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aleksmaus @elasticmachine @james-elastic @scunningham