Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Enable configuring monitoring namespace #26439

Merged
merged 8 commits into from
Jun 29, 2021
Merged

[Elastic Agent] Enable configuring monitoring namespace #26439

merged 8 commits into from
Jun 29, 2021

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jun 23, 2021 •
edited
Loading

What does this PR do?

This PR adds a config option which is used as monitoring namespace.
This namespace is injected to data_stream section of the event and alters index name as well following our naming convention.

Config option is also reloadable and will be applied on change without a need of restarting agent

Why is it important?

Fixes: #25350

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added v7.14.0 Team:Elastic-Agent Label for the Agent team labels Jun 23, 2021
@michalpristas michalpristas self-assigned this Jun 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 23, 2021
@botelastic
Copy link

botelastic bot commented Jun 23, 2021

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 23, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26439 updated

  • Start Time: 2021-06-29T06:26:24.570+0000

  • Duration: 83 min 31 sec

  • Commit: 77997b1

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6972
Skipped 16
Total 6988

@mergify
Copy link
Contributor

mergify bot commented Jun 23, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/monitoring-namespace upstream/feat/monitoring-namespace
git merge upstream/master
git push upstream feat/monitoring-namespace

blakerouse
blakerouse approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feat/monitoring-namespace upstream/feat/monitoring-namespace
git merge upstream/master
git push upstream feat/monitoring-namespace

@michalpristas michalpristas merged commit bba9cfd into elastic:master Jun 29, 2021
michalpristas added a commit to michalpristas/beats that referenced this pull request Jun 29, 2021
@michalpristas
[Elastic Agent] Enable configuring monitoring namespace (elastic#26439)
ce14415 
[Elastic Agent] Enable configuring monitoring namespace (elastic#26439)
@michalpristas michalpristas added enhancement needs_backport PR is waiting to be backported to other branches. labels Jun 29, 2021
@michalpristas michalpristas mentioned this pull request Jun 29, 2021
Merged
6 tasks
michalpristas added a commit that referenced this pull request Jun 29, 2021
@michalpristas
[Elastic Agent] Enable configuring monitoring namespace (#26439) (#26555
8e0c1a1 
)

[Elastic Agent] Enable configuring monitoring namespace (#26439)
@dikshachauhan-qasource
Copy link

Hi @EricDavisX @michalpristas

Could you please share AC to validate this.

Thanks
QAS

v1v added a commit to v1v/beats that referenced this pull request Jun 29, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-d…
2c9f25c 
…arwin-arm64

* upstream/master: (295 commits)
  Update urllib to 1.26.5. (elastic#26380)
  Update golang.org/x/crypto (elastic#26448)
  [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816)
  Move parsers outside of filestream input so others can use them as well (elastic#26541)
  [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508)
  [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620)
  Logging code cleanup related to Nomad auto-discovery (elastic#26498)
  [Metricbeat] Add Couchbase's Sync Gateway module (elastic#25599)
  Refactor add_cloud_metadata to handle ECS fields easier (elastic#26438)
  [Elastic Agent] Improper casting of int64 (elastic#26520)
  [Elastic Agent] Enable configuring monitoring namespace (elastic#26439)
  [Heartbeat] configure permissions for synthetics config (elastic#26393)
  Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545)
  [Heartbeat] add screenshots config to synthetics (elastic#26455)
  [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474)
  Remove all docs about  Beats central management (elastic#26399)
  update data.json for gcp billing (elastic#26506)
  Skip x-pack metricbeat tests (elastic#26537)
  [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529)
  Add changelog entry for  elastic#26224 (elastic#26531)
  ...
@EricDavisX
Copy link
Contributor

@dikshachauhan-qasource I believe this is covered under elastic/kibana#100500 which you have since confirmed is ok. If you need more specs / AC please do ping Michal or Andres or PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

Assignees

@michalpristas michalpristas

Labels
enhancement needs_backport PR is waiting to be backported to other branches. Team:Elastic-Agent Label for the Agent team v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elastic Agent should allow a namespace to be configured
5 participants
@michalpristas @elasticmachine @dikshachauhan-qasource @EricDavisX @blakerouse