Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] add screenshots config to synthetics #26455

Merged
merged 2 commits into from
Jun 28, 2021
Merged

[Heartbeat] add screenshots config to synthetics #26455

merged 2 commits into from
Jun 28, 2021

Conversation

vigneshshanmugam
Copy link
Member

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 23, 2021
@vigneshshanmugam vigneshshanmugam added Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0 labels Jun 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 23, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 23, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26455 updated

  • Start Time: 2021-06-28T16:34:26.608+0000

  • Duration: 81 min 46 sec

  • Commit: c195125

Test stats 🧪

Test Results
Failed 0
Passed 3358
Skipped 90
Total 3448

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3358
Skipped 90
Total 3448

andrewvc
andrewvc reviewed Jun 24, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, but needs docs! Can you add this option to https://github.com/elastic/beats/blob/master/heartbeat/docs/monitors/monitor-browser.asciidoc

@andrewvc andrewvc mentioned this pull request Jun 24, 2021
Closed
@vigneshshanmugam vigneshshanmugam requested a review from a team as a code owner June 28, 2021 16:34
andrewvc
andrewvc approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work

andrewvc
andrewvc approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@andrewvc andrewvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vigneshshanmugam vigneshshanmugam merged commit 7ca5909 into elastic:master Jun 28, 2021
@vigneshshanmugam vigneshshanmugam deleted the add-screenshots-option branch June 28, 2021 20:31
@vigneshshanmugam
Copy link
Member Author

@Mergifyio backport 7.x

mergify bot pushed a commit that referenced this pull request Jun 28, 2021
@vigneshshanmugam
[Heartbeat] add screenshots config to synthetics (#26455)
b869b51 
* [Heartbeat] add screenshots config to synthetics

* docs: update screenshot docs

(cherry picked from commit 7ca5909)
@mergify mergify bot mentioned this pull request Jun 28, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2021

Command backport 7.x: success

Backports have been created

andrewvc pushed a commit that referenced this pull request Jun 28, 2021
@mergify @vigneshshanmugam
[Heartbeat] add screenshots config to synthetics (#26455) (#26547)
063aaba 
* [Heartbeat] add screenshots config to synthetics

* docs: update screenshot docs

(cherry picked from commit 7ca5909)

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 29, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
d4a87cb 
* master:
  Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545)
  [Heartbeat] add screenshots config to synthetics (elastic#26455)
  [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474)
  Remove all docs about  Beats central management (elastic#26399)
  update data.json for gcp billing (elastic#26506)
  Skip x-pack metricbeat tests (elastic#26537)
  [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529)
  Add changelog entry for  elastic#26224 (elastic#26531)
  Add inttests for the x-pack/metricbeat on a PR/branches basis (elastic#26526)
  Suppress too many errors (elastic#26224)
  Fix master's linting issue (elastic#26517)
  [libbeat] Fix encoding and file offset issues in the disk queue (elastic#26484)
  Add log_group_name_prefix config option for aws-cloudwatch input (elastic#26187)
  Update shared-deduplication.asciidoc (elastic#26492)
  Add Recorded Future support to threatintel module (elastic#26481)
v1v added a commit to v1v/beats that referenced this pull request Jun 29, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/support-d…
2c9f25c 
…arwin-arm64

* upstream/master: (295 commits)
  Update urllib to 1.26.5. (elastic#26380)
  Update golang.org/x/crypto (elastic#26448)
  [Filebeat] Update Fortinet Ingest Pipeline (elastic#24816)
  Move parsers outside of filestream input so others can use them as well (elastic#26541)
  [Filebeat] Fix `threatintel.indicator.url.full` field not populating (elastic#26508)
  [Filebeat] Add network direction processor to Zeek and Suricata modules (elastic#24620)
  Logging code cleanup related to Nomad auto-discovery (elastic#26498)
  [Metricbeat] Add Couchbase's Sync Gateway module (elastic#25599)
  Refactor add_cloud_metadata to handle ECS fields easier (elastic#26438)
  [Elastic Agent] Improper casting of int64 (elastic#26520)
  [Elastic Agent] Enable configuring monitoring namespace (elastic#26439)
  [Heartbeat] configure permissions for synthetics config (elastic#26393)
  Osquerybeat: set the raw index name to supress the timestamp suffix (elastic#26545)
  [Heartbeat] add screenshots config to synthetics (elastic#26455)
  [Elastic Agent] Use http2 to connect to Fleet Server. (elastic#26474)
  Remove all docs about  Beats central management (elastic#26399)
  update data.json for gcp billing (elastic#26506)
  Skip x-pack metricbeat tests (elastic#26537)
  [Elastic Agent] Fix issue with FLEET_CA not being used with Fleet Server in container (elastic#26529)
  Add changelog entry for  elastic#26224 (elastic#26531)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewvc andrewvc andrewvc approved these changes

Assignees
No one assigned
Labels
Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.14.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vigneshshanmugam @elasticmachine @andrewvc