Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Elastic Agent] Adjust installation path in container #27396

Merged
merged 8 commits into from
Aug 17, 2021
Merged

[Elastic Agent] Adjust installation path in container #27396

merged 8 commits into from
Aug 17, 2021

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Aug 16, 2021 •
edited
Loading

What does this PR do?

Adjusts the installation path inside the Elastic Agent container so the extraction path is inside the original container and not in the STATE_PATH.

Why is it important?

The STATE_PATH is normally a bind mount and when it is a hostPath bind mount it is set with noexec in Kubernetes. This change allows that hostPath to be used as the installation path will now stay in the original container path.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse blakerouse added Team:Elastic-Agent Label for the Agent team backport-v7.15.0 Automated backport with mergify labels Aug 16, 2021
@blakerouse blakerouse self-assigned this Aug 16, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 16, 2021
@blakerouse
Copy link
Contributor Author

/package

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 16, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-17T14:00:27.241+0000

  • Duration: 88 min 23 sec

  • Commit: 828711a

Test stats 🧪

Test Results
Failed 0
Passed 7012
Skipped 16
Total 7028

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7012
Skipped 16
Total 7028

@blakerouse blakerouse mentioned this pull request Aug 17, 2021
Closed
3 tasks
@blakerouse blakerouse marked this pull request as ready for review August 17, 2021 14:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b k8s-install-path upstream/k8s-install-path
git merge upstream/master
git push upstream k8s-install-path

michel-laterman
michel-laterman approved these changes Aug 17, 2021
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerouse blakerouse merged commit 9ce228f into elastic:master Aug 17, 2021
@blakerouse blakerouse deleted the k8s-install-path branch August 17, 2021 17:54
mergify bot pushed a commit that referenced this pull request Aug 17, 2021
@blakerouse
[Elastic Agent] Adjust installation path in container (#27396)
eeeefbd 
* Adjust atomic installer to extract in the install directory, removing the need to rename across filesystem boundaries.

* Add comment.

* Add changelog.

* Fix install path on k8s.

* Fix issue with paths.

* Cleanup temps.

* Add changelog.

(cherry picked from commit 9ce228f)
@mergify mergify bot mentioned this pull request Aug 17, 2021
Merged
blakerouse added a commit that referenced this pull request Aug 17, 2021
@mergify @blakerouse
[Elastic Agent] Adjust installation path in container (#27396) (#27432)
e3348df 
* Adjust atomic installer to extract in the install directory, removing the need to rename across filesystem boundaries.

* Add comment.

* Add changelog.

* Fix install path on k8s.

* Fix issue with paths.

* Cleanup temps.

* Add changelog.

(cherry picked from commit 9ce228f)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
@pebrc pebrc mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

@faec faec faec approved these changes

Assignees

@blakerouse blakerouse

Labels
backport-v7.15.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
4 participants
@blakerouse @elasticmachine @faec @michel-laterman