Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metricbeat] CI: update stack to 7.14 #27416

Merged
merged 4 commits into from
Aug 17, 2021

Conversation

endorama
Copy link
Member

What does this PR do?

Update CI docker images to 7.14.0

Why is it important?

7.12.0 (currently in use for testing Metricbeat) is old and unsupported.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama added the Team:Integrations Label for the Integrations team label Aug 17, 2021
@endorama endorama requested a review from jsoriano August 17, 2021 08:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 17, 2021
@endorama
Copy link
Member Author

@aspacca was suggesting to update to 7.15 instead, per #27220

As 7.15 is the next minor and to my understanding we still don't have builds to tests against.

We would be testing against nightly, but that's not something we usually do (or am I wrong?)

@aspacca
Copy link

aspacca commented Aug 17, 2021

#27220 was merged yesterday requiring Kibana 7.15 and ndjson format for dashboards.
I wonder if we should rather bump CI versions to 7.x or similar

@endorama
Copy link
Member Author

@aspacca what if we do this in 2 steps? First let's update to 7.14 (we are already late for this), to unblock other work streams.

Then we update to 7.15 as soon as the first BC is out to test the new dashboards format.

@aspacca
Copy link

aspacca commented Aug 17, 2021

@endorama , it would be fine for me.

@jsoriano
Copy link
Member

jsoriano commented Aug 17, 2021

#27220 was merged yesterday requiring Kibana 7.15 and ndjson format for dashboards.

This format was supported by Kibana before 7.0, there shouldn't be any problem with using it in any 7.x version of Kibana, 7.14 should be fine.

I wonder if we should rather bump CI versions to 7.x or similar.

We should use released versions whenever possible. Using development versions has the risk of introducing unstability in our pipelines.

We should also use released versions of Kibana to create dashboards, so there are less risks of using features that are not available or are different in final versions. Also, the older the version of Kibana used to create the dashboard, the broader support for older versions the dashboard has.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it looks good to Mario and Jenkins 🙂

@jsoriano
Copy link
Member

jsoriano commented Aug 17, 2021

Then we update to 7.15 as soon as the first BC is out to test the new dashboards format.

To be clear, 7.15 is not needed to test or use the new dashboard format (proof of it is that builds are green in #27220 - well, the relevant tests for dashboards are 🙂 ), this format was already available in all 7.x versions and before. The reason to make the change in Beats 7.15 is because Kibana is going to remove the old format at the latest in 8.0, so Beats needs to migrate to the new format before 7.last.

@aspacca
Copy link

aspacca commented Aug 17, 2021

@jsoriano thanks for the clarification: I might have missed some context indeed.

On #27220 I saw a version check in libbeat requiring minimum Kibana 7.15.0 ff1ca85 and was not sure if this would be hit on CI

@jsoriano
Copy link
Member

@jsoriano thanks for the clarification: I might have missed some contest indeed.

On #27220 I saw a version check in libbeat requiring minimum Kibana 7.15.0 ff1ca85 and was not sure if this would be hit on CI

Umm, this is interesting, I may be wrong then 🙂 Not sure why adding this limitation, in principle the Saved Objects API is supported way before 7.15 (https://www.elastic.co/guide/en/kibana/7.14/saved-objects-api.html).

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 17, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-08-17T14:25:55.508+0000

  • Duration: 106 min 45 sec

  • Commit: 4579588

Test stats 🧪

Test Results
Failed 0
Passed 9644
Skipped 2540
Total 12184

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 9644
Skipped 2540
Total 12184

@endorama endorama force-pushed the metricbeat-update-test-stack-7.14 branch from 066d789 to ece1ea8 Compare August 17, 2021 12:00
@endorama
Copy link
Member Author

So for some reason now the integration tests fail with

E               Exception: Key 'beat.stats.info.version' found in event is not documented!

Any idea why?

@jsoriano
Copy link
Member

So for some reason now the integration tests fail with

E               Exception: Key 'beat.stats.info.version' found in event is not documented!

Any idea why?

It seems that the stats metricset in the beat module is collecting a (new?) field that is not documented. @sayden could you take a look?

@endorama as you only need to update Kibana and Elasticsearch to unblock your PR, an option could be to update them by now and keep the metricbeat version in the docker compose file as is.

This reverts commit ece1ea8.

This change is producing an error in the CI
Exception: Key 'beat.stats.info.version' found in event is not documented!

Reverting to get to a stable build.
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@endorama
Copy link
Member Author

All green, merging.

@endorama endorama merged commit 2eb4601 into elastic:master Aug 17, 2021
@endorama endorama deleted the metricbeat-update-test-stack-7.14 branch August 17, 2021 16:28
@jsoriano jsoriano added the backport-v7.15.0 Automated backport with mergify label Aug 19, 2021
@jsoriano jsoriano added the backport-v7.16.0 Automated backport with mergify label Aug 19, 2021
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
(cherry picked from commit 2eb4601)

# Conflicts:
#	metricbeat/docker-compose.yml
#	x-pack/metricbeat/docker-compose.yml
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
@jsoriano
Copy link
Member

Adding backport labels for this, as seems required by #27470. @endorama there was any reason to don't backport this change to 7.x? cc @kvch

@endorama
Copy link
Member Author

@jsoriano not at all, most probably I forgot in the heat of the moment.

A sidenote is that this PR did not update beats-metricbeat so now there are different versions for elasticsearch, kibana and metricbeat.

kvch pushed a commit that referenced this pull request Aug 19, 2021
* [Metricbeat] CI: update stack to 7.14 (#27416)

(cherry picked from commit 2eb4601)

# Conflicts:
#	metricbeat/docker-compose.yml
#	x-pack/metricbeat/docker-compose.yml

* Fix conflicts

Co-authored-by: endorama <526307+endorama@users.noreply.github.com>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants