-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat] CI: update stack to 7.14 #27416
[Metricbeat] CI: update stack to 7.14 #27416
Conversation
Pinging @elastic/integrations (Team:Integrations) |
#27220 was merged yesterday requiring Kibana 7.15 and |
@aspacca what if we do this in 2 steps? First let's update to 7.14 (we are already late for this), to unblock other work streams. Then we update to 7.15 as soon as the first BC is out to test the new dashboards format. |
@endorama , it would be fine for me. |
This format was supported by Kibana before 7.0, there shouldn't be any problem with using it in any 7.x version of Kibana, 7.14 should be fine.
We should use released versions whenever possible. Using development versions has the risk of introducing unstability in our pipelines. We should also use released versions of Kibana to create dashboards, so there are less risks of using features that are not available or are different in final versions. Also, the older the version of Kibana used to create the dashboard, the broader support for older versions the dashboard has. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it looks good to Mario and Jenkins 🙂
To be clear, 7.15 is not needed to test or use the new dashboard format (proof of it is that builds are green in #27220 - well, the relevant tests for dashboards are 🙂 ), this format was already available in all 7.x versions and before. The reason to make the change in Beats 7.15 is because Kibana is going to remove the old format at the latest in 8.0, so Beats needs to migrate to the new format before 7.last. |
Umm, this is interesting, I may be wrong then 🙂 Not sure why adding this limitation, in principle the Saved Objects API is supported way before 7.15 (https://www.elastic.co/guide/en/kibana/7.14/saved-objects-api.html). |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
066d789
to
ece1ea8
Compare
So for some reason now the integration tests fail with
Any idea why? |
It seems that the stats metricset in the beat module is collecting a (new?) field that is not documented. @sayden could you take a look? @endorama as you only need to update Kibana and Elasticsearch to unblock your PR, an option could be to update them by now and keep the metricbeat version in the docker compose file as is. |
This reverts commit ece1ea8. This change is producing an error in the CI Exception: Key 'beat.stats.info.version' found in event is not documented! Reverting to get to a stable build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤞
All green, merging. |
(cherry picked from commit 2eb4601) # Conflicts: # metricbeat/docker-compose.yml # x-pack/metricbeat/docker-compose.yml
(cherry picked from commit 2eb4601)
@jsoriano not at all, most probably I forgot in the heat of the moment. A sidenote is that this PR did not update |
* [Metricbeat] CI: update stack to 7.14 (#27416) (cherry picked from commit 2eb4601) # Conflicts: # metricbeat/docker-compose.yml # x-pack/metricbeat/docker-compose.yml * Fix conflicts Co-authored-by: endorama <526307+endorama@users.noreply.github.com> Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
What does this PR do?
Update CI docker images to 7.14.0
Why is it important?
7.12.0 (currently in use for testing Metricbeat) is old and unsupported.
Checklist
My code follows the style guidelines of this projectI have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs