Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricbeat/ci: update metricbeat version to 7.14 #27494

Closed

Conversation

endorama
Copy link
Member

@endorama endorama commented Aug 19, 2021

What does this PR do?

Update beats-metricbeat docker container used for testing to 7.14.0

Why is it important?

In #27416 the beats-metricbeat image has not been update because was producing a test failure. To unblock other work it was decided to postpone that update to a later date.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@endorama endorama requested a review from jsoriano August 19, 2021 10:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 19, 2021
@endorama endorama added the Team:Integrations Label for the Integrations team label Aug 19, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 19, 2021
@jsoriano jsoriano added the backport-v7.16.0 Automated backport with mergify label Aug 19, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-02-03T10:18:25.713+0000

  • Duration: 113 min 53 sec

  • Commit: 3c19149

Test stats 🧪

Test Results
Failed 0
Passed 7028
Skipped 2288
Total 9316

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@botelastic
Copy link

botelastic bot commented Sep 18, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Sep 18, 2021
@endorama
Copy link
Member Author

@jsoriano what do you think we should do on this one? As #27495 is still open and we are already behind one version (7.15) I'm not sure this PR is still valid. But the issue is still there and I'd like to address it.

@botelastic botelastic bot removed the Stalled label Oct 13, 2021
@jsoriano
Copy link
Member

@jsoriano what do you think we should do on this one? As #27495 is still open and we are already behind one version (7.15) I'm not sure this PR is still valid. But the issue is still there and I'd like to address it.

Well, someone should take a look to #27495, if you can do it, great 🙂

@sayden
Copy link
Contributor

sayden commented Oct 13, 2021

elasticsearch, kibana, logstash and beats modules cannot be backported to 7.x because they have a massive refactor. That message of beat.stats.info.version should come from beats master branch, not from any 7.x.

I actually don't know where it can come from, because on master branch code that''s beat.version and not info.version.

Is it possible that in the attempt to update metricbeat to use 7.14 the CI it actually pulled master?

@botelastic
Copy link

botelastic bot commented Nov 12, 2021

Hi!
We just realized that we haven't looked into this PR in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it in as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Nov 12, 2021
@endorama
Copy link
Member Author

Waiting on #28782 to land to move this forward. I think is superseded, but in any case at the moment is blocked.

@botelastic botelastic bot removed the Stalled label Nov 15, 2021
@endorama endorama self-assigned this Nov 15, 2021
@jsoriano
Copy link
Member

I think this can be moved forward 🙂 Thanks @endorama and @sayden!

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b metricbeat-update-test-metricbeat-7.14 upstream/metricbeat-update-test-metricbeat-7.14
git merge upstream/main
git push upstream metricbeat-update-test-metricbeat-7.14

@jlind23
Copy link
Collaborator

jlind23 commented Mar 31, 2022

Not relevant anymore, closing it.

@jlind23 jlind23 closed this Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metricbeat used in CI to test the beat module
5 participants