Change "filebeat.config.modules.enabled" to "true"

[hubbleview]

As per https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-configuration-reloading.html#load-module-config, the default value of filebeat.config.modules.enabled is true.

Having it as false in filebeat.reference.yml is confusing.

[mergify]

This pull request does not have a backport label. Could you fix it @hubbleview? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[elasticmachine]

Pinging @elastic/obs-docs (Team:Docs)

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-11-23T18:38:52.722+0000

• Duration: 105 min 54 sec

• Commit: 9eb4b6f

Test stats 🧪

Test	Results
Failed	0
Passed	9517
Skipped	1275
Total	10792

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages and run the E2E tests.

• /beats-tester : Run the installation tests with beats-tester.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[bplies-ATX]

Similar for

#filebeat.config:
  #inputs:
    #enabled: false

for that matter? enabled should be true also?

[dedemorton]

I know why the CI is broken here. I will fix it and make sure this PR gets merged.

[dedemorton]

I'm checking with the development team to see what the rule is for commented-out lines in the reference.yml. I think they might be setting up the file so that it's easier for users to disable config loading for modules by uncommenting the line (rather than having to uncomment and change the value to false). I can see where this would be confusing to users, though!

Let's wait to hear back, but it might be better just to remove enabled: true from the example in the docs rather than changing the yaml file.

[dedemorton]

@adriansr Can you comment on this change. I think the default in versions prior to 8.0 is still true, no? What would you recommend to fix the confusion this is causing for users?

[adriansr]

@dedemorton this PR refers to the filebeat.config.modules.enabled flag, which is a global flag to disable module loading completely, and it's different to what we have recently changed.

Both in 8.x and in 7.x, the filebeat.config.modules.enabled defaults to true. What has changed is each individual fileset enabled flag, which in 8.x defaults to false so that users explicitly select the filesets they want to use.

I think it makes sense for the reference configuration (commented-out or not) to mirror the actual default values.

@hubbleview , this PR is modifying an autogenerated file. You should apply this change to filebeat/_meta/beat.reference.yml and then $ mage update in filebeat/ and x-pack/filebeat/.

[dedemorton]

@hubbleview I can fix the PR if you don't already have a beats development environment set up. Just let me know. Thanks!

[dedemorton]

I've pushed changes that should fix the CI failure.

[hubbleview]

Thank you @dedemorton for fixing this, sorry I missed out this PR for long time.

[ruflin]

Do we really need to backport this to 7.15? Doesn't look like an urgent bugfix.

[hubbleview]

Not necessary to backport to 7.15.0, I just removed that label. @ruflin