Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heartbeat: remove w2008 in the CI #29093

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 23, 2021

What does this PR do?

remove w2008 in the CI for heartbeat

Why is it important?

  • Win2k8 was already old when heartbeat was created
  • It's quite unusual to put heartbeat on a 'legacy' machine
  • We've never heard of anyone using heartbeat+win2k8
  • The win2k8 tests are flaky

Win2k8 was already old when heartbeat was created

It's quite unusual to put heartbeat on a 'legacy' machine

We've never heard of anyone using heartbeat+win2k8

The win2k8 tests are flaky
@v1v v1v added Heartbeat backport-v8.0.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Nov 23, 2021
@v1v v1v requested review from andrewvc, ruflin and a team November 23, 2021 09:51
@v1v v1v self-assigned this Nov 23, 2021
@v1v v1v requested a review from a team as a code owner November 23, 2021 09:51
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc As a follow up, could you go through the list and check what you actually need for the heartbeat tests to be run? Maybe there are more things inside that we can drop.

I assume this will also have an affect on the support matrix?

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-23T09:52:12.145+0000

  • Duration: 72 min 48 sec

  • Commit: 821fcc0

Test stats 🧪

Test Results
Failed 0
Passed 3145
Skipped 71
Total 3216

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v added the Team:Automation Label for the Observability productivity team label Nov 23, 2021
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 23, 2021
@v1v v1v merged commit 6ef54ee into elastic:master Nov 23, 2021
mergify bot pushed a commit that referenced this pull request Nov 23, 2021
mergify bot pushed a commit that referenced this pull request Nov 23, 2021
v1v added a commit that referenced this pull request Nov 23, 2021
(cherry picked from commit 6ef54ee)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit that referenced this pull request Nov 23, 2021
(cherry picked from commit 6ef54ee)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
v1v added a commit to v1v/beats that referenced this pull request Nov 24, 2021
…ws-on-file-changes

* upstream/master:
  override host on statsd metricset (elastic#29103)
  Skip config check in autodiscover for duplicated configurations (elastic#29048)
  Change "filebeat.config.modules.enabled" to "true" (elastic#28769)
  Remove deprecated spool queue from Beats (elastic#28869)
  Add `beat` field back to beat.stats (elastic#29094)
  Revert "Move labels and annotations under kubernetes.namespace. (elastic#27917)" (elastic#29069)
  heartbeat: remove w2008 in the CI (elastic#29093)
  Remove deprecated `--template` and `--index-policy` flags (elastic#28870)
  Fix parsing of apache trace log levels (elastic#28717)
  [Elastic-Agent] IUse itnernal port for local fleet server (elastic#28993)
  [Heartbeat] Log error on dupe monitor ID instead of strict req (elastic#29041)
  Enable pprof for elastic-agent and beats (elastic#28983)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.16.0 Automated backport with mergify backport-v8.0.0 Automated backport with mergify Heartbeat Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants