packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows #32180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/windows Also use windows.GetAdaptersAddresses and windows.IpAdapterAddresses (now complete).
efd6
added
Packetbeat
cleanup
Team:Security-External Integrations
backport-skip
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
|
Packaging failures are unrelated. |
andrewkroh
approved these changes
Jul 6, 2022
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jul 7, 2022
…tomation * upstream/main: [main](backport elastic#32235) docs: Prepare Changelog for 8.3.2 (elastic#32253) Revert "Fix flags for dev build (elastic#31955)" (elastic#32250) [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (elastic#32243) x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (elastic#32196) packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows (elastic#32180)
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…/windows (#32180) Also use windows.GetAdaptersAddresses and windows.IpAdapterAddresses (now complete).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This uses the now-available x/sys/windows functions to obtain the information that we previously used locally defined calls for.
Why is it important?
This reduces maintenance burden.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs