Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields #32196

Merged
merged 1 commit into from
Jul 6, 2022
Merged

x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields #32196

merged 1 commit into from
Jul 6, 2022

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 5, 2022

What does this PR do?

This fixes handing of user parsing when there are SGT values associated with the user.

Why is it important?

Without this change the pipeline fails when SGT values are logged with users.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Filebeat Filebeat Team:Security-External Integrations Integration:Cisco backport-v8.3.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify 8.4-candidate labels Jul 5, 2022
@efd6 efd6 self-assigned this Jul 5, 2022
@efd6 efd6 requested a review from a team as a code owner July 5, 2022 07:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 5, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 5, 2022 •
edited by jenkins-beats-ci bot
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-06T22:01:21.564+0000

  • Duration: 75 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 6274
Skipped 737
Total 7011

Steps errors 2

Expand to view the steps failures

filebeat-packaging-linux - mage package
  • Took 5 min 5 sec . View more details here
  • Description: mage package
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'hudson.AbortException: script returned exit code 1'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 32009-cisco upstream/32009-cisco
git merge upstream/main
git push upstream 32009-cisco

@efd6
Copy link
Contributor Author

efd6 commented Jul 6, 2022

Packaging failure is unrelated.

@efd6 efd6 merged commit f8622ed into elastic:main Jul 6, 2022
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
@efd6 @mergify
x-pack/filebeat/module/cisco: fix handling of user parsing with sgt f…
3f7344c 
…ields (#32196)

(cherry picked from commit f8622ed)

# Conflicts:
#	x-pack/filebeat/module/cisco/fields.go
@mergify mergify bot mentioned this pull request Jul 6, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 6, 2022
@efd6 @mergify
x-pack/filebeat/module/cisco: fix handling of user parsing with sgt f…
a9eab3d 
…ields (#32196)

(cherry picked from commit f8622ed)
@mergify mergify bot mentioned this pull request Jul 6, 2022
Merged
efd6 added a commit that referenced this pull request Jul 7, 2022
@mergify @efd6
x-pack/filebeat/module/cisco: fix handling of user parsing with sgt f…
2052d6d 
…ields (#32196) (#32239)

(cherry picked from commit f8622ed)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
v1v added a commit to v1v/beats that referenced this pull request Jul 7, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/ironbank-au…
cc6dd56 
…tomation

* upstream/main:
  [main](backport elastic#32235) docs: Prepare Changelog for 8.3.2 (elastic#32253)
  Revert "Fix flags for dev build (elastic#31955)" (elastic#32250)
  [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (elastic#32243)
  x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (elastic#32196)
  packetbeat/route: make use of newly added GetBestInterfaceEx in x/sys/windows (elastic#32180)
efd6 added a commit that referenced this pull request Aug 31, 2022
@mergify @efd6
[7.17](backport #32196) x-pack/filebeat/module/cisco: fix handling of…
94a1b3f 
… user parsing with sgt fields (#32238)

* x-pack/filebeat/module/cisco: fix handling of user parsing with sgt fields (#32196)

(cherry picked from commit f8622ed)

# Conflicts:
#	x-pack/filebeat/module/cisco/fields.go

* fix conflict
* fix expectations
* update CHANGELOG.next.asciidoc

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @efd6
x-pack/filebeat/module/cisco: fix handling of user parsing with sgt f…
bb206e0 
…ields (elastic#32196) (elastic#32239)

(cherry picked from commit f8622ed)

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@efd6 @chrisberkhout
x-pack/filebeat/module/cisco: fix handling of user parsing with sgt f…
89d35e3 
…ields (#32196)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
8.4-candidate backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.3.0 Automated backport with mergify bug Filebeat Filebeat Integration:Cisco
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat][Cisco Module][ASA] Cisco ASA VPN logs ingest pipeline failure
3 participants
@efd6 @elasticmachine @andrewkroh