Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ELU fields to metricbeat Kibana module. #35020

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

lukeelmers
Copy link
Member

@lukeelmers lukeelmers commented Apr 4, 2023

This PR updates the Metricbeat kibana module with support for the new event_loop_utilization field added to Kibana in elastic/kibana#153717. We plan to use this metric for autoscaling in serverless, so metricbeat needs to know about it.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

- module: kibana
  metricsets:
    - stats # be sure to enable stats metricset
  period: 10s
  hosts: ["localhost:5601"]
  basepath: "abc" # whatever your base path is
  username: "elastic"
  password: "changeme"
  • ./metricbeat -e
  • create metricbeat-* data view in kibana
  • you should now be seeing some log entries which contain event_loop_utilization

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 4, 2023
@mergify

This comment was marked as outdated.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-18T23:59:08.562+0000

  • Duration: 51 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 4367
Skipped 885
Total 5252

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lukeelmers lukeelmers force-pushed the feat/add-kibana-elu branch from 3af31c5 to a370008 Compare April 5, 2023 22:28
@lukeelmers lukeelmers force-pushed the feat/add-kibana-elu branch from a370008 to d045a92 Compare April 6, 2023 00:47
@lukeelmers lukeelmers added the backport-skip Skip notification from the automated backport with mergify label Apr 6, 2023
@lukeelmers lukeelmers marked this pull request as ready for review April 6, 2023 20:52
@lukeelmers lukeelmers requested a review from a team as a code owner April 6, 2023 20:52
@lukeelmers lukeelmers added the Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring label Apr 6, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 6, 2023
@lukeelmers
Copy link
Member Author

cc @elastic/kibana-core

Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

metricbeat/module/kibana/stats/data.go Show resolved Hide resolved
--

[float]
=== event_loop_utilization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kibana module can either route data to metricbeat-* or .monitoring-kibana-8-mb depending on the xpack.enabled value provided. The monitoring-* template is defined in elasticsearch, could you also add the mappings there ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing - opened PR here: elastic/elasticsearch#95388

@lukeelmers
Copy link
Member Author

@elasticmachine run elasticsearch-ci/docs

@lukeelmers
Copy link
Member Author

Thanks @klacabane - looks like I don't have permissions to merge, would you mind merging this when you are ready?

@klacabane
Copy link
Contributor

🚢

@klacabane klacabane merged commit 1824ce9 into elastic:main Apr 20, 2023
@lukeelmers lukeelmers deleted the feat/add-kibana-elu branch May 3, 2023 22:40
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
* Add ELU fields to metricbeat Kibana module.

* Update changelog.

* Run make update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify >enhancement Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants