Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event_loop_utilization Kibana stats to the monitoring index templates #95388

Merged
merged 3 commits into from
Apr 20, 2023
Merged

Add event_loop_utilization Kibana stats to the monitoring index templates #95388

merged 3 commits into from
Apr 20, 2023

Conversation

lukeelmers
Copy link
Member

Adds mappings for kibana.stats.process.event_loop_utilization to the monitoring templates.

Corresponding Beats PR: elastic/beats#35020

@lukeelmers lukeelmers self-assigned this Apr 19, 2023
@elasticsearchmachine elasticsearchmachine added v8.8.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Apr 19, 2023
@elasticsearchmachine
Copy link
Collaborator

Hi @lukeelmers, I've created a changelog YAML for you.

@lukeelmers lukeelmers force-pushed the feat/monitoring-kibana-elu branch from 54ab7fe to 56b29a7 Compare April 19, 2023 17:54
@lukeelmers lukeelmers force-pushed the feat/monitoring-kibana-elu branch from 56b29a7 to 330dada Compare April 19, 2023 18:04
@lukeelmers lukeelmers marked this pull request as ready for review April 19, 2023 20:33
@lukeelmers lukeelmers requested a review from a team as a code owner April 19, 2023 20:33
@lukeelmers lukeelmers added the Team:Data Management Meta label for data/management team label Apr 19, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@lukeelmers lukeelmers mentioned this pull request Apr 19, 2023
Merged
5 tasks
@lukeelmers lukeelmers requested a review from klacabane April 19, 2023 20:37
@klacabane
Copy link
Contributor

We also need to increment this value https://github.com/klacabane/elasticsearch/blob/main/x-pack/plugin/monitoring/src/main/java/org/elasticsearch/xpack/monitoring/MonitoringTemplateRegistry.java#L81

@lukeelmers
Copy link
Member Author

@klacabane Thanks! Updated

klacabane
klacabane approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukeelmers lukeelmers merged commit 2815232 into elastic:main Apr 20, 2023
@lukeelmers lukeelmers deleted the feat/monitoring-kibana-elu branch April 20, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klacabane klacabane klacabane approved these changes

Assignees

@lukeelmers lukeelmers

Labels
:Data Management/Monitoring >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukeelmers @elasticsearchmachine @klacabane