[Heartbeat] Remove synthetics support for ironbank #35551

emilioalvap · 2023-05-23T17:33:32Z

What does this PR do?

Remove Synthetics support and files from ironbank build.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
~~[ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.~~

How to test this PR locally

Follow original PR to enable ironbank instructions: #32954.

elasticmachine · 2023-05-23T17:33:35Z

Pinging @elastic/uptime (Team:Uptime)

mergify · 2023-05-23T17:34:08Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2023-05-23T19:27:37Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2023-05-25T16:48:27.191+0000
Duration: 123 min 25 sec

Test stats 🧪

Test	Results
Failed	0
Passed	26422
Skipped	1975
Total	28397

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewvc

LGTM

v1v · 2023-05-24T06:27:05Z

/package

v1v · 2023-05-24T06:29:19Z

I've just contributed to your PR and deleted some other files related to:

In addition, I triggered the package pipeline with the above-command, and there is an extra requirement to delete those artifacts from the Unified Release, let me put a PR for that.

I also included all the backport labels

This reverts commit 544cfd6.

v1v · 2023-05-24T06:35:56Z

/package

This reverts commit 1e6b816.

This reverts commit 0c533e7.

This reverts commit afa51b7.

This reverts commit e34fa74.

This reverts commit b0e0ad0.

v1v · 2023-05-24T08:59:52Z

/package

* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) # Conflicts: # dev-tools/packaging/templates/ironbank/heartbeat/hardening_manifest.yaml

* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5)

* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>

* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>

…nbank (#35588) * [Heartbeat] Remove synthetics support for ironbank (#35551) * [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) # Conflicts: # dev-tools/packaging/templates/ironbank/heartbeat/hardening_manifest.yaml * Manual merge --------- Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>

[Heartbeat] Remove synthetics support for ironbank

ff47744

emilioalvap added Team:obs-ds-hosted-services Label for the Observability Hosted Services team cleanup release-note:skip The PR should be ignored when processing the changelog labels May 23, 2023

emilioalvap requested a review from a team as a code owner May 23, 2023 17:33

emilioalvap requested review from pierrehilbert and cmacknz May 23, 2023 17:33

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 23, 2023

mergify bot assigned emilioalvap May 23, 2023

cmacknz approved these changes May 23, 2023

View reviewed changes

andrewvc approved these changes May 23, 2023

View reviewed changes

pierrehilbert approved these changes May 24, 2023

View reviewed changes

v1v added 4 commits May 24, 2023 08:17

ci: remove heartbeat ironbank validation

b0e0ad0

ci: remove heartbeat ironbank validation scheduler

e34fa74

remove heartbeat ironbank

afa51b7

avoid running it

0c533e7

elasticmachine requested a review from a team as a code owner May 24, 2023 06:26

botelastic bot added the Team:Automation Label for the Observability productivity team label May 24, 2023

v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.7.0 Automated backport with mergify backport-v8.8.0 Automated backport with mergify labels May 24, 2023

Revert "ironbank: support for heartbeat (elastic#32954)"

1e6b816

This reverts commit 544cfd6.

Revert "Revert "ironbank: support for heartbeat (elastic#32954)""

ec8ba1b

This reverts commit 1e6b816.

v1v added 4 commits May 24, 2023 10:58

Revert "avoid running it"

6243615

This reverts commit 0c533e7.

Revert "remove heartbeat ironbank"

954f794

This reverts commit afa51b7.

Revert "ci: remove heartbeat ironbank validation scheduler"

72bb754

This reverts commit e34fa74.

Revert "ci: remove heartbeat ironbank validation"

2e275f2

This reverts commit b0e0ad0.

emilioalvap and others added 2 commits May 25, 2023 12:02

Merge branch 'main' into hb-disable-synthetics-ironbank

7e4c507

update version

e7fcb3e

emilioalvap merged commit 3f5afa5 into elastic:main May 26, 2023

mergify bot mentioned this pull request May 26, 2023

[7.17](backport #35551) [Heartbeat] Remove synthetics support for ironbank #35588

Merged

This was referenced May 26, 2023

[8.7](backport #35551) [Heartbeat] Remove synthetics support for ironbank #35589

Merged

[8.8](backport #35551) [Heartbeat] Remove synthetics support for ironbank #35590

Merged

reakaleek mentioned this pull request Jul 19, 2023

Fix ironbank validation in 8.8 #36115

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Heartbeat] Remove synthetics support for ironbank #35551

[Heartbeat] Remove synthetics support for ironbank #35551

emilioalvap commented May 23, 2023

elasticmachine commented May 23, 2023

mergify bot commented May 23, 2023

elasticmachine commented May 23, 2023 •

edited by jenkins-beats-ci bot

Loading

Build stats

Test stats 🧪

andrewvc left a comment

v1v commented May 24, 2023

v1v commented May 24, 2023

v1v commented May 24, 2023

v1v commented May 24, 2023

[Heartbeat] Remove synthetics support for ironbank #35551

[Heartbeat] Remove synthetics support for ironbank #35551

Conversation

emilioalvap commented May 23, 2023

What does this PR do?

Checklist

How to test this PR locally

elasticmachine commented May 23, 2023

mergify bot commented May 23, 2023

elasticmachine commented May 23, 2023 • edited by jenkins-beats-ci bot Loading

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

andrewvc left a comment

Choose a reason for hiding this comment

v1v commented May 24, 2023

v1v commented May 24, 2023

v1v commented May 24, 2023

v1v commented May 24, 2023

elasticmachine commented May 23, 2023 •

edited by jenkins-beats-ci bot

Loading