-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ironbank: support for heartbeat #32954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since it requires the tar.gz from the mage package
…nd the stack works as expected
…ackaging * upstream/main: (109 commits) Add cap_net_raw requirements to heartbeat docs (elastic#32816) apply a quick hotfix for having main working properly (elastic#32934) action: checks for x-pack/libbeat and libbeat (elastic#32754) Update to Go 1.18 in go.mod. (elastic#32940) [heartbeat] disable browser code on windows via build tags (elastic#32939) action: checks for heartbeat and x-pack/heartbeat (elastic#32749) Make event acknowledgment asynchronous in shipper output (elastic#32785) [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (elastic#32930) Preallocate memory to reduce GC load (elastic#32905) [Automation] Update elastic stack version to 8.5.0-440e0896 for testing (elastic#32919) Skip broken ceph tests. (elastic#32912) Use non-deprecated docker image for testing jolokia (elastic#32885) update ironbank image product name (elastic#32867) ci: pre-commit stage within Jenkins (elastic#32839) Fix a couple of bugs in the logic for how AWS metric periods are calculated (elastic#32724) [Filebeat] [httpjson] Add support for single string containing multiple relation-types in getRFC5988Link (elastic#32811) [Heartbeat] Update HB k8s template to use <Mi> metric (elastic#32801) action: checks for metricbeat and x-pack/metricbeat (elastic#32748) action: checks for filebeat and x-pack/filebeat (elastic#32746) allow for json/ndjson content type with charset (elastic#32767) ...
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 1, 2022
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
v1v
added
automation
Team:Automation
Label for the Observability productivity team
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-v8.4.0
Automated backport with mergify
labels
Sep 1, 2022
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 1, 2022
v1v
requested review from
belimawr,
rdner and
cmacknz
and removed request for
a team
September 1, 2022 10:59
rdner
approved these changes
Sep 1, 2022
➜ /tmp gsutil cp gs://beats-ci-artifacts/beats/pull-requests/pr-32954/heartbeat/heartbeat-ironbank-8.5.0-SNAPSHOT-docker-build-context.tar.gz .
Copying gs://beats-ci-artifacts/beats/pull-requests/pr-32954/heartbeat/heartbeat-ironbank-8.5.0-SNAPSHOT-docker-build-context.tar.gz...
/ [1 files][ 25.7 KiB/ 25.7 KiB]
Operation completed over 1 objects/25.7 KiB.
➜ /tmp tar -xvf heartbeat-ironbank-8.5.0-SNAPSHOT-docker-build-context.tar.gz
x Dockerfile
x LICENSE
x README.md
x hardening_manifest.yaml
x signatures
x signatures/RPM-GPG-KEY-CentOS-Official
x signatures/RPM-GPG-KEY-rockyofficial
x signatures/linux_signing_key.pub
➜ /tmp grep 8.5.0 *
Dockerfile:ARG ELASTIC_STACK=8.5.0
README.md:[here](https://www.elastic.co/guide/en/beats/libbeat/current/release-notes-8.5.0.html).
hardening_manifest.yaml: - "8.5.0"
hardening_manifest.yaml: ELASTIC_STACK: "8.5.0"
hardening_manifest.yaml: org.opencontainers.image.version: "8.5.0"
hardening_manifest.yaml: - filename: "heartbeat-8.5.0-linux-x86_64.tar.gz"
hardening_manifest.yaml: url: "<artifact_path>/heartbeat-8.5.0-linux-x86_64.tar.gz"
hardening_manifest.yaml: value: e327d8469bd71ea0d747673bc362240e3ddad672a0eb7fe815a06d1317e74598 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
(cherry picked from commit 544cfd6)
mergify bot
pushed a commit
that referenced
this pull request
Sep 1, 2022
(cherry picked from commit 544cfd6)
v1v
added a commit
that referenced
this pull request
Sep 1, 2022
v1v
pushed a commit
that referenced
this pull request
Sep 2, 2022
4 tasks
elasticmachine
pushed a commit
to emilioalvap/beats
that referenced
this pull request
May 24, 2023
This reverts commit 544cfd6.
elasticmachine
pushed a commit
to emilioalvap/beats
that referenced
this pull request
May 24, 2023
This reverts commit 1e6b816.
emilioalvap
added a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) # Conflicts: # dev-tools/packaging/templates/ironbank/heartbeat/hardening_manifest.yaml
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5)
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5)
emilioalvap
added a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
emilioalvap
added a commit
that referenced
this pull request
May 26, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
* [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
emilioalvap
added a commit
that referenced
this pull request
Jun 14, 2023
…nbank (#35588) * [Heartbeat] Remove synthetics support for ironbank (#35551) * [Heartbeat] Remove synthetics support for ironbank * ci: remove heartbeat ironbank validation * ci: remove heartbeat ironbank validation scheduler * remove heartbeat ironbank * avoid running it * Revert "ironbank: support for heartbeat (#32954)" This reverts commit 544cfd6. * Revert "Revert "ironbank: support for heartbeat (#32954)"" This reverts commit 1e6b816. * Revert "avoid running it" This reverts commit 0c533e7. * Revert "remove heartbeat ironbank" This reverts commit afa51b7. * Revert "ci: remove heartbeat ironbank validation scheduler" This reverts commit e34fa74. * Revert "ci: remove heartbeat ironbank validation" This reverts commit b0e0ad0. * update version --------- Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com> (cherry picked from commit 3f5afa5) # Conflicts: # dev-tools/packaging/templates/ironbank/heartbeat/hardening_manifest.yaml * Manual merge --------- Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com> Co-authored-by: emilioalvap <emilio.alvarezpineiro@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
backport-7.17
Automated backport to the 7.17 branch with mergify
backport-v8.4.0
Automated backport with mergify
Team:Automation
Label for the Observability productivity team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Automate the docker context generation for the Heartbeat IronBank releases, this will allow us to move away from creating those docker context manually in a different repository, since the Platform Release team already provide the automation.
Implementation details
mage ironbank
DoD build context content
As required the build context contains the following files:
Dockerfile
with specific requirements for DoD (registry args, no internet dependencies, healthcheck, ...)hardening_manifest.yaml
with all required dependenciesLICENSE
specific for DoDREADME.md
with specific content for DoDconfig/
(optional) directory containing all config files to include into the Docker imagescripts/
directory containing all scripts to include into the Docker image (example: entrypoint...)Why is it important?
No more manual post-release steps to generate the ironbank releases for heartbeat
Actions
tar.gz
docker context following the Unified Release requirementshardening_manifest.yaml
that includes all the dependencies.Test
produced
Issues
A similar approach was done for other beats.
It also contains the fix put in place in #32867 but for heartbeats