-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.13](backport #39126) Beats DRA pipeline #39198
Conversation
* Packaging pipieline resource * Revetred agentbeat pipeline deletion * Cleanup * Test auditbeat packaging pipeline * Fix steps keys * Fix steps keys * Fix env vars * Fix env vars * Fix env vars * Unified artifacts dir * Implemented DRA steps * Test filebeat * Test matrix * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Aligned artifacts directories * Debug * Debug * Package all beats * Test DRA snapshot * Test DRA snapshot * Rename artifacts * fix dashboards artifacts * Cleanup * cleanup * No need to install msi tools * Apply suggestions from code review Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> * Extraced platforms variables * Cleanup * Added RUN_SNAPSHOT condition * Cleanup * Boolean dry-run * Boolean dry-run --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com> (cherry picked from commit c6444db) # Conflicts: # .buildkite/packaging.pipeline.yml
Cherry-pick of c6444db has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This pull request doesn't have a |
This PR fixes a number of bugs from #39126
This commit fixes the error "interpolating remaining fields: Expected identifier to start with a letter, got /"
This commit fixes the release-manager error > # > java.io.FileNotFoundException: /artifacts/build/distributions/... (Permission denied) by adjusting the permissions of parent directories. Additionally there are a few logging enhancements to improve debugging, as well as the introduction of a new optional `DRA_BRANCH` environment variable, to help running and debugging via PRs. Relates elastic/ingest-dev#3095 --------- Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co> Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
…39217) Added DEV flag to snapshot builds. Specified the workflow for prepare-release-manager.sh Relates: elastic/ingest-dev#3095
This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏 |
As things are now we allow parallel builds on the packaging pipeline, which could result in out of order artifacts (depending on which one takes longer to finish). This commit implements two "queues" (snapshot/staging) to ensure ordered builds of DRA artifacts. Relates elastic/ingest-dev#3095
The DRA staging release is failing because the Buildkite step isn't capturing the right artifacts. This commit fixes the issue by adjusting the artifact_paths to match the other steps.
* Fix the annotating for snapshot and staging This commit adds the `--append` flag to the buildkite-annotate so that when it is called by the snapshot and staging steps, it will not overwrite the other annotation. Signed-off-by: Alexandros Sapranidis <alexandros@elastic.co>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #39293 introduced one concurrency queue per staging/snapshot but this slows down unnecessarily concurrent DRA builds for main and other release branches. This commit makes the concurrency gates (additionally) specific per branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: elastic/ingest-dev#3095 [^1]: elastic#39198
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: elastic/ingest-dev#3095 [^1]: #39198
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad)
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad)
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad)
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Now that DRA support via Buildkite has also been backported to 8.13[^1] this commit widens the whitelisted branches that can trigger Buildkite DRA builds to include all 8.x branches. Relates: https://github.com/elastic/ingest-dev/issues/3095 [^1]: #39198 (cherry picked from commit 7e203ad) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Proposed commit message
Beats Packaging pipeline
Migrates packaging.groovy to buildkite.
Buildkite packaging pipeline is used to build and publish the packages for the Beats. The pipeline is triggered by a commit to the
main
or release branches.The pipeline definition is located in the
.buildkite/packaging.pipeline.yml
Triggers
Staging packaging DRA is triggered for the
main
and release branches.Snapshot can be triggered for any branch by the
/package
comment in the PR. The release-manager dry-run will be used for PR builds.Pipeline steps
Beats dashboards
Generates
build/distributions/dependencies.csv
and adds it to thebeats-dashboards
artifact. Thedependencies.csv
is required by the release-manager configurationPackaging snapshot/staging
mage package, mage ironbank
)build/distributions/<beat>/
directory and adds it as an artifact. Where<beat>
is the name of the beatbuild/distributions/<beat>/
directory, where<beat>
is the name of the beat. For example,auditbeat
, notx-pack/auditbeat
DRA publish
Downloads the artifacts from the
packaging snapshot/staging
step and publishes them to the Elastic DRA registry.Snapshot publishing example (Dry run)
Beats-tester and e2e tests are not triggered
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #39126 done by [Mergify](https://mergify.com).