Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14](backport #39818) [Heartbeat] Move import to cmd for agentbeat #39819

Merged
merged 1 commit into from
Jun 6, 2024
Merged

[8.14](backport #39818) [Heartbeat] Move import to cmd for agentbeat #39819

merged 1 commit into from
Jun 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 6, 2024 •
edited by zube bot
Loading

Proposed commit message

Fix browser plugin import to be bundled inside agentbeat, which is now being skipped and it prevents browser monitors from working.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Browser monitors do not work as part of agentbeat.

How to test this PR locally

  1. Build and package elastic-agent-complete locally.
  2. Enroll in a private location.
  3. Create a browser monitor and check agentbeat does not error out with:
Error creating runner from config: factory could not create monitor: monitor type browser does not exist, valid types are [synthetics/icmp tcp synthetics/tcp http synthetics/http icmp]
This is an automatic backport of pull request #39818 done by [Mergify](https://mergify.com).

@emilioalvap @mergify
[Heartbeat] Move import to cmd for agentbeat (#39818)
41e46fb 
* [Heartbeat] Move import to cmd for agentbeat

Fix browser plugin import to be bundled inside agentbeat, which is now being skipped and it prevents browser monitors from working.

(cherry picked from commit 727777e)
@mergify mergify bot requested a review from a team as a code owner June 6, 2024 15:25
@mergify mergify bot added the backport label Jun 6, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 6, 2024
@emilioalvap emilioalvap added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 6, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@emilioalvap emilioalvap merged commit 4c4b2f8 into 8.14 Jun 6, 2024
16 checks passed
@emilioalvap emilioalvap deleted the mergify/bp/8.14/pr-39818 branch June 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilioalvap emilioalvap emilioalvap approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elasticmachine @emilioalvap