Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Move import to cmd for agentbeat #39818

Merged
merged 2 commits into from
Jun 6, 2024
Merged

[Heartbeat] Move import to cmd for agentbeat #39818

merged 2 commits into from
Jun 6, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented Jun 6, 2024 •
edited
Loading

Proposed commit message

Fix browser plugin import to be bundled inside agentbeat, which is now being skipped and it prevents browser monitors from working.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Browser monitors do not work as part of agentbeat.

How to test this PR locally

  1. Build and package elastic-agent-complete locally.
  2. Enroll in a private location.
  3. Create a browser monitor and check agentbeat does not error out with:
Error creating runner from config: factory could not create monitor: monitor type browser does not exist, valid types are [synthetics/icmp tcp synthetics/tcp http synthetics/http icmp]

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-v8.14.0 Automated backport with mergify labels Jun 6, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner June 6, 2024 14:36
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 6, 2024
@emilioalvap emilioalvap merged commit 727777e into elastic:main Jun 6, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request Jun 6, 2024
@emilioalvap @mergify
[Heartbeat] Move import to cmd for agentbeat (#39818)
41e46fb 
* [Heartbeat] Move import to cmd for agentbeat

Fix browser plugin import to be bundled inside agentbeat, which is now being skipped and it prevents browser monitors from working.

(cherry picked from commit 727777e)
@mergify mergify bot mentioned this pull request Jun 6, 2024
Merged
6 tasks
emilioalvap added a commit that referenced this pull request Jun 6, 2024
@mergify @emilioalvap
[Heartbeat] Move import to cmd for agentbeat (#39818) (#39819)
4c4b2f8 
* [Heartbeat] Move import to cmd for agentbeat

Fix browser plugin import to be bundled inside agentbeat, which is now being skipped and it prevents browser monitors from working.

(cherry picked from commit 727777e)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
@emilioalvap emilioalvap mentioned this pull request Jun 7, 2024
Merged
6 tasks
@mergify mergify bot mentioned this pull request Jun 7, 2024
Merged
6 tasks
@cmacknz cmacknz mentioned this pull request Oct 21, 2024
Draft
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees

@emilioalvap emilioalvap

Labels
backport-v8.14.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilioalvap @elasticmachine @vigneshshanmugam