Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Unit test plugin import at cmd level #39830

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

emilioalvap
Copy link
Collaborator

Proposed commit message

Related to #39818.

Add unit test to cover plugin imports at cmd module, to be run from agentbeat.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-v8.14.0 Automated backport with mergify labels Jun 7, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner June 7, 2024 16:46
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 7, 2024
@emilioalvap emilioalvap merged commit 3b24698 into elastic:main Jun 7, 2024
23 checks passed
mergify bot pushed a commit that referenced this pull request Jun 7, 2024
* [Heartbeat] Unit test plugin imports inside cmd module
Add unit test to cover plugin imports at cmd module, to be run from agentbeat.

(cherry picked from commit 3b24698)
vigneshshanmugam pushed a commit that referenced this pull request Jun 7, 2024
* [Heartbeat] Unit test plugin imports inside cmd module
Add unit test to cover plugin imports at cmd module, to be run from agentbeat.

(cherry picked from commit 3b24698)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants