[vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40456

kush-elastic · 2024-08-08T06:01:39Z

Enhancement

Description

Added following new metrics for the ResourcePool datastream in the vSphere metricbeat module. added new performance API to get more detailled info from the vSphere.

Metrics Type	Metrics	API	Field Mappings
Resource pools CPU/memory/status	OverallCpuUsage	Quickstats	cpu.usage.mhz
	OverallCpuDemand	Quickstats	cpu.demand.mhz
	GuestMemoryUsage	Quickstats	memory.usage.guest.bytes
	HostMemoryUsage	Quickstats	memory.usage.host.bytes
	DistributedCpuEntitlement	Quickstats	cpu.entitlement.mhz
	DistributedMemoryEntitlement	Quickstats	memory.entitlement.bytes
	StaticCpuEntitlement	Quickstats	cpu.entitlement.static.mhz
	StaticMemoryEntitlement	Quickstats	memory.entitlement.static.mhz
	PrivateMemory	Quickstats	memory.private.bytes
	SharedMemory	Quickstats	memory.shared.bytes
	SwappedMemory	Quickstats	memory.swapped.bytes
	BalloonedMemory	Quickstats	memory.ballooned.bytes
	OverheadMemory	Quickstats	memory.overhead.bytes
	ConsumedOverheadMemory	Quickstats	memory.overhead.consumed.bytes
	CompressedMemory	Quickstats	memory.compressed.bytes
	reourcepool.status	Summary	status
	resourcepool.Vm	Summary	vm.names
			vm.count

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Relates https://github.com/elastic/obs-integration-team/issues/21

- Add new Metricset - add/update docs - add unit tests - local testing

mergify · 2024-08-08T06:02:15Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kush-elastic? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

elasticmachine · 2024-08-08T06:47:18Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

…tricset

metricbeat/module/vsphere/resourcepool/_meta/fields.yml

elasticmachine · 2024-08-19T13:44:42Z

Pinging @elastic/integrations (Team:Integrations)

metricbeat/module/vsphere/resourcepool/resourcepool.go

mergify · 2024-08-28T13:46:11Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 21-vsphere-implement-the-new-resourcepool-metricset upstream/21-vsphere-implement-the-new-resourcepool-metricset
git merge upstream/main
git push upstream 21-vsphere-implement-the-new-resourcepool-metricset

metricbeat/module/vsphere/resourcepool/_meta/fields.yml

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

…vsphere-implement-the-new-resourcepool-metricset

kush-elastic · 2024-08-29T06:46:19Z

/test

devamanv

Shared last set of review comments, rest looks good to me!

metricbeat/module/vsphere/resourcepool/data.go

metricbeat/module/vsphere/resourcepool/data_test.go

…tricset

kush-elastic · 2024-08-29T10:22:28Z

/test

ishleenk17

Looks good!

lucian-ioan

LGTM

…tricset

ishleenk17 · 2024-08-29T15:02:51Z

/test

…etricset (#40456) * [vSphere][ResourcePool]: - Add new Metricset - add/update docs - add unit tests - local testing * add changelog entry * golangci-lint fix * add vm names per resourcePool * mage update * update changelog entry * make update * resolve review comment * make update * update changelog entry * resolved review comments * resolve review comments * field updates * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * update changelog entry * minor changes --------- Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> (cherry picked from commit 1f77e6e) # Conflicts: # metricbeat/docs/modules/vsphere.asciidoc # metricbeat/docs/modules_list.asciidoc # metricbeat/include/list_common.go # metricbeat/metricbeat.reference.yml # metricbeat/module/vsphere/_meta/README.md # metricbeat/module/vsphere/_meta/config.reference.yml # metricbeat/module/vsphere/_meta/config.yml # metricbeat/module/vsphere/_meta/docs.asciidoc # metricbeat/module/vsphere/fields.go # metricbeat/modules.d/vsphere.yml.disabled # x-pack/metricbeat/metricbeat.reference.yml

…etricset (#40456) * [vSphere][ResourcePool]: - Add new Metricset - add/update docs - add unit tests - local testing * add changelog entry * golangci-lint fix * add vm names per resourcePool * mage update * update changelog entry * make update * resolve review comment * make update * update changelog entry * resolved review comments * resolve review comments * field updates * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com> * update changelog entry * minor changes --------- Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

…etricset (#40456) (#40825) * [vSphere][ResourcePool]: - Add new Metricset - add/update docs - add unit tests - local testing * add changelog entry * golangci-lint fix * add vm names per resourcePool * mage update * update changelog entry * make update * resolve review comment * make update * update changelog entry * resolved review comments * resolve review comments * field updates * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml * Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml * update changelog entry * minor changes --------- Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com>

[vSphere][ResourcePool]:

0858fd0

- Add new Metricset - add/update docs - add unit tests - local testing

kush-elastic requested review from a team as code owners August 8, 2024 06:01

kush-elastic requested review from AndersonQ and leehinman August 8, 2024 06:01

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2024

kush-elastic requested review from lalit-satapathy, ishleenk17, harnish-elastic and niraj-elastic and removed request for AndersonQ and leehinman August 8, 2024 06:02

mergify bot assigned kush-elastic Aug 8, 2024

kush-elastic added enhancement module Metricbeat Metricbeat Module:beat The beat Metricbeat module Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Aug 8, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 8, 2024

kush-elastic added 2 commits August 8, 2024 11:36

add changelog entry

5e1b64c

golangci-lint fix

c653b3c

pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 8, 2024

Merge branch 'main' into 21-vsphere-implement-the-new-resourcepool-me…

d975d37

…tricset

harnish-elastic requested changes Aug 16, 2024

View reviewed changes

lalit-satapathy added Team:Integrations Label for the Integrations team and removed Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Aug 19, 2024

gpop63 reviewed Aug 28, 2024

View reviewed changes

metricbeat/module/vsphere/resourcepool/resourcepool.go Show resolved Hide resolved

ishleenk17 reviewed Aug 29, 2024

View reviewed changes

kush-elastic and others added 5 commits August 29, 2024 11:12

Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

266e031

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

ae7e453

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

0b30d2c

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

Merge branch 'main' of https://github.com/kush-elastic/beats into 21-…

036d2d6

…vsphere-implement-the-new-resourcepool-metricset

update changelog entry

b26056c

kush-elastic requested review from harnish-elastic, devamanv and ishleenk17 August 29, 2024 06:27

shmsr approved these changes Aug 29, 2024

View reviewed changes

harnish-elastic approved these changes Aug 29, 2024

View reviewed changes

devamanv approved these changes Aug 29, 2024

View reviewed changes

metricbeat/module/vsphere/resourcepool/data.go Show resolved Hide resolved

metricbeat/module/vsphere/resourcepool/data.go Show resolved Hide resolved

metricbeat/module/vsphere/resourcepool/data_test.go Outdated Show resolved Hide resolved

kush-elastic and others added 2 commits August 29, 2024 12:36

minor changes

6025a7c

Merge branch 'main' into 21-vsphere-implement-the-new-resourcepool-me…

ba03a89

…tricset

ishleenk17 approved these changes Aug 29, 2024

View reviewed changes

lucian-ioan approved these changes Aug 29, 2024

View reviewed changes

AndersonQ approved these changes Aug 29, 2024

View reviewed changes

Merge branch 'main' into 21-vsphere-implement-the-new-resourcepool-me…

0071311

…tricset

ishleenk17 merged commit 1f77e6e into elastic:main Aug 29, 2024
29 checks passed

ishleenk17 added the backport-8.15 Automated backport to the 8.15 branch with mergify label Sep 12, 2024

mergify bot mentioned this pull request Sep 12, 2024

[8.15](backport #40456) [vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40789

Closed

6 tasks

ishleenk17 mentioned this pull request Sep 13, 2024

[8.15](backport #40456) [vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40825

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40456

[vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40456

kush-elastic commented Aug 8, 2024 •

edited

Loading

mergify bot commented Aug 8, 2024

elasticmachine commented Aug 8, 2024

elasticmachine commented Aug 19, 2024

mergify bot commented Aug 28, 2024

kush-elastic commented Aug 29, 2024

devamanv left a comment •

edited

Loading

kush-elastic commented Aug 29, 2024

ishleenk17 left a comment

lucian-ioan left a comment

ishleenk17 commented Aug 29, 2024

[vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40456

[vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40456

Conversation

kush-elastic commented Aug 8, 2024 • edited Loading

Description

Checklist

Related issues

mergify bot commented Aug 8, 2024

elasticmachine commented Aug 8, 2024

elasticmachine commented Aug 19, 2024

mergify bot commented Aug 28, 2024

kush-elastic commented Aug 29, 2024

devamanv left a comment • edited Loading

Choose a reason for hiding this comment

kush-elastic commented Aug 29, 2024

ishleenk17 left a comment

Choose a reason for hiding this comment

lucian-ioan left a comment

Choose a reason for hiding this comment

ishleenk17 commented Aug 29, 2024

kush-elastic commented Aug 8, 2024 •

edited

Loading

devamanv left a comment •

edited

Loading