Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #40456) [vSphere][resourcepool] Add support for new metrics in resourcepool metricset #40825

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

ishleenk17
Copy link
Contributor

This is a manual backport of pull request #40456.

  • Enhancement

Description

Added following new metrics for the ResourcePool datastream in the vSphere metricbeat module. added new performance API to get more detailled info from the vSphere.

Metrics Type Metrics API Field Mappings
Resource pools CPU/memory/status OverallCpuUsage Quickstats cpu.usage.mhz
  OverallCpuDemand Quickstats cpu.demand.mhz
  GuestMemoryUsage Quickstats memory.usage.guest.bytes
  HostMemoryUsage Quickstats memory.usage.host.bytes
  DistributedCpuEntitlement Quickstats cpu.entitlement.mhz
  DistributedMemoryEntitlement Quickstats memory.entitlement.bytes
  StaticCpuEntitlement Quickstats cpu.entitlement.static.mhz
  StaticMemoryEntitlement Quickstats memory.entitlement.static.mhz
  PrivateMemory Quickstats memory.private.bytes
  SharedMemory Quickstats memory.shared.bytes
  SwappedMemory Quickstats memory.swapped.bytes
  BalloonedMemory Quickstats memory.ballooned.bytes
  OverheadMemory Quickstats memory.overhead.bytes
  ConsumedOverheadMemory Quickstats memory.overhead.consumed.bytes
  CompressedMemory Quickstats memory.compressed.bytes
  reourcepool.status Summary status
  resourcepool.Vm Summary vm.names
      vm.count

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

…etricset (#40456)

* [vSphere][ResourcePool]:
- Add new Metricset
- add/update docs
- add unit tests
- local testing

* add changelog entry

* golangci-lint fix

* add vm names per resourcePool

* mage update

* update changelog entry

* make update

* resolve review comment

* make update

* update changelog entry

* resolved review comments

* resolve review comments

* field updates

* Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

* Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

* Update metricbeat/module/vsphere/resourcepool/_meta/fields.yml

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>

* update changelog entry

* minor changes

---------

Co-authored-by: Ishleen Kaur <102962586+ishleenk17@users.noreply.github.com>
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 13, 2024
@botelastic
Copy link

botelastic bot commented Sep 13, 2024

This pull request doesn't have a Team:<team> label.

@ishleenk17 ishleenk17 marked this pull request as ready for review September 14, 2024 01:29
@ishleenk17 ishleenk17 requested review from a team as code owners September 14, 2024 01:29
@ishleenk17 ishleenk17 requested review from AndersonQ and mauri870 and removed request for a team September 14, 2024 01:29
Copy link
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM backport.

@ishleenk17 ishleenk17 merged commit 7c12246 into 8.15 Sep 14, 2024
29 checks passed
@ishleenk17 ishleenk17 deleted the vsphere/bp/8.15/pr-40456 branch September 14, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants