Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix templates and docs to use correct -- command line args #42060

Merged
merged 5 commits into from
Jan 3, 2025
Merged

fix templates and docs to use correct -- command line args #42060

merged 5 commits into from
Jan 3, 2025
+138 −31

Conversation

leehinman
Copy link
Contributor

@leehinman leehinman commented Dec 16, 2024 •
edited
Loading

Proposed commit message

Change use of -environment and -system.hostfs to the correct --environment and --system.hostfs versions in templates and documentation. This is necessary to allow correct argument parsing in all environments.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Closes #42038

@leehinman leehinman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team bugfix labels Dec 16, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 16, 2024
@cmacknz cmacknz mentioned this pull request Dec 16, 2024
Closed
@leehinman leehinman force-pushed the 42038_argument_fix branch 3 times, most recently from a634cce to 63f7d70 Compare December 17, 2024 18:26
@leehinman leehinman marked this pull request as ready for review December 17, 2024 18:45
@leehinman leehinman requested review from a team as code owners December 17, 2024 18:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@cmacknz cmacknz added the backport-8.17 Automated backport with mergify label Dec 17, 2024
belimawr
belimawr reviewed Dec 18, 2024
View reviewed changes
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
dev-tools/mage/pkg.go Show resolved Hide resolved
andrzej-stencel
andrzej-stencel approved these changes Dec 23, 2024
View reviewed changes
dev-tools/packaging/package_test.go Outdated Show resolved Hide resolved
@jlind23
Copy link
Collaborator

jlind23 commented Dec 31, 2024

@cmacknz can I get your approval on this before I bypass the obs-cloudnative-monitoring review? I would like this fix to land in 8.17 asap.

@pkoutsovasilis pkoutsovasilis mentioned this pull request Dec 31, 2024
Open
@leehinman leehinman enabled auto-merge (squash) January 2, 2025 19:30
@jlind23
Copy link
Collaborator

jlind23 commented Jan 2, 2025

@gizas @tetianakravchenko looks like we still need on of your approval in order to move forward here.

@leehinman leehinman merged commit 580f0f6 into elastic:main Jan 3, 2025
149 checks passed
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@leehinman @mergify
fix templates and docs to use correct -- command line args (#42060)
b83f5b2 
* fix templates and docs to use correct `--` command line args

Co-authored-by: Tiago Queiroz <me@tiago.life>

(cherry picked from commit 580f0f6)
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@leehinman @mergify
fix templates and docs to use correct -- command line args (#42060)
a0eb1ea 
* fix templates and docs to use correct `--` command line args

Co-authored-by: Tiago Queiroz <me@tiago.life>

(cherry picked from commit 580f0f6)
This was referenced Jan 3, 2025
Merged
Merged
jlind23 pushed a commit that referenced this pull request Jan 6, 2025
@mergify @leehinman
[8.x](backport #42060) fix templates and docs to use correct -- com…
d523b05 
…mand line args (#42204)

* fix templates and docs to use correct `--` command line args (#42060)

* fix templates and docs to use correct `--` command line args

Co-authored-by: Tiago Queiroz <me@tiago.life>

(cherry picked from commit 580f0f6)

* fix changelog

---------

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
jlind23 pushed a commit that referenced this pull request Jan 6, 2025
@mergify @leehinman
[8.17](backport #42060) fix templates and docs to use correct -- co…
945c5c1 
…mmand line args (#42205)

* fix templates and docs to use correct `--` command line args (#42060)

* fix templates and docs to use correct `--` command line args

Co-authored-by: Tiago Queiroz <me@tiago.life>

(cherry picked from commit 580f0f6)

* fix changelog

---------

Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com>
Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr left review comments

@constanca-m constanca-m constanca-m approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@jlind23 jlind23 jlind23 approved these changes

@mauri870 mauri870 mauri870 approved these changes

@gizas gizas Awaiting requested review from gizas gizas is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko is a code owner automatically assigned from elastic/obs-cloudnative-monitoring

@rdner rdner Awaiting requested review from rdner rdner is a code owner automatically assigned from elastic/elastic-agent-data-plane

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@leehinman leehinman

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify bugfix Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8.17.0 docker containers not starting with default arguments
8 participants
@leehinman @elasticmachine @jlind23 @belimawr @mauri870 @andrzej-stencel @constanca-m @cmacknz