Update metricbeat-kubernetes.yaml

[524c]

The docker.elastic.co/beats/metricbeat-wolfi:8.17.0 image has a problem with -system.hostfs=/hostfs argument (one dash)

[cla-checker-service]

❌ Author of the following commits did not sign a Contributor Agreement:
8fe2396

Please, read and sign the above mentioned agreement if you want to contribute to this project

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @524c? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

[mergify]

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

[pkoutsovasilis]

Based on this code this is a flag string cli arg, thus the single dash is correct. Do you face an issue with this code @524c? PS: our documentation has this flag with double dashes but this is also allowed

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[524c]

Based on this code this is a flag string cli arg, thus the single dash is correct. Do you face an issue with this code @524c? PS: our documentation has this flag with double dashes but this is also allowed

Hi, yes I get a error with version 8.17.0: https://raw.githubusercontent.com/elastic/beats/8.17/deploy/kubernetes/metricbeat-kubernetes.yaml

No working:

      - name: metricbeat
        image: docker.elastic.co/beats/metricbeat-wolfi:8.17.0
        args: [
          "-c", "/etc/metricbeat.yml",
          "-e",
          "-system.hostfs=/hostfs",
        ]

Working:

      - name: metricbeat
        image: docker.elastic.co/beats/metricbeat-wolfi:8.17.0
        args: [
          "-c", "/etc/metricbeat.yml",
          "-e",
          "--system.hostfs=/hostfs",
        ]

[524c]

Based on this code this is a flag string cli arg, thus the single dash is correct. Do you face an issue with this code @524c? PS: our documentation has this flag with double dashes but this is also allowed

And with 8.1.4.3 work with single and double dash (metricbeat image):

      - name: metricbeat
        image: docker.elastic.co/beats/metricbeat:8.14.3
        args: [
          "-c", "/etc/metricbeat.yml",
          "-e",
          "-system.hostfs=/hostfs",
        ]

[pkoutsovasilis]

UPDATE: I believe this issue is already being handled in this PR 🙂

@524c I believe what you are seeing is bug, ty 🙏 AFAICT this PR affected how metribeat parses cli args but if my understanding is correct system.hostfs should be backwards compatible, aka both -system.hostfs and --system.hostfs should be supported. @leehinman since you are the author of this PR is my understanding correct or something else is going on here? 🙂