-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove settings from docs #4753
Conversation
urso
commented
Jul 25, 2017
- remove removed settings in libbeat/filebeat docs
- add tags/fields/fields_under_root/processor settings to every beat
02d9bed
to
70b37f2
Compare
70b37f2
to
4d87e36
Compare
4d87e36
to
5ff1c34
Compare
@@ -192,6 +192,14 @@ top-level fields in the output document instead of being grouped under a | |||
names added by Filebeat, then the custom fields overwrite the other fields. | |||
|
|||
[float] | |||
===== `processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be level 4 (====
), not 5.
@@ -123,6 +123,44 @@ value specified for `timeout` is greater than `schedule`, intermediate checks | |||
will not be executed by the scheduler. | |||
|
|||
[float] | |||
[[monitor-fields]] | |||
===== `fields` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
|
||
[float] | ||
[[monitor-fields-under-root]] | ||
===== `fields_under_root` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
|
||
[float] | ||
[[monitor-tags]] | ||
===== `tags` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
|
||
[float] | ||
[[monitor-processors]] | ||
===== `processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
libbeat/docs/generalconfig.asciidoc
Outdated
@@ -91,15 +91,12 @@ fields: | |||
------------------------------------------------------------------------------ | |||
|
|||
[float] | |||
==== `queue_size` | |||
===== `processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
@@ -353,6 +353,41 @@ in time. Periodical reporting can be disabled by setting the value to -1. If | |||
disabled, flows are still reported once being timed out. The default value is | |||
10s. | |||
|
|||
[float] | |||
[[packetbeat-configuration-flows-fields]] | |||
===== `fields` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
will be overwritten by the value declared here. | ||
|
||
[float] | ||
===== `fields_under_root` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
fields. | ||
|
||
[float] | ||
===== `tags` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
A list of tags that will be sent with the protocol event. This setting is optional. | ||
|
||
[float] | ||
===== `processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
@@ -485,6 +520,19 @@ under a `fields` sub-dictionary. If the custom field names conflict with other | |||
field names added by Packetbeat, then the custom fields overwrite the other | |||
fields. | |||
|
|||
[float] | |||
===== `tags` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
A list of tags that will be sent with the transaction event. This setting is optional. | ||
|
||
[float] | ||
===== `processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
@@ -340,3 +341,11 @@ under a `fields` sub-dictionary. If the custom field names conflict with other | |||
field names added by Winlogbeat, then the custom fields overwrite the other | |||
fields. | |||
|
|||
[float] | |||
===== `event_logs.processors` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be level 4 (====
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor comments (one change to apply in multiple places).
Otherwise, LGTM
- remove removed settings in libbeat/filebeat docs - add tags/fields/fields_under_root/processor settings to every beat
5ff1c34
to
8435e3f
Compare
- remove removed settings in libbeat/filebeat docs - add tags/fields/fields_under_root/processor settings to every beat (cherry picked from commit 4b7f097)
- remove removed settings in libbeat/filebeat docs - add tags/fields/fields_under_root/processor settings to every beat (cherry picked from commit 2c07801)