-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #4753 to 6.0: Remove settings from docs #4878
Conversation
- remove removed settings in libbeat/filebeat docs - add tags/fields/fields_under_root/processor settings to every beat (cherry picked from commit 4b7f097)
[[monitor-fields-under-root]] | ||
==== `fields_under_root` | ||
|
||
If this option is set to true, the custom <<monitor-fields>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this to say,
the custom <<monitor-fields,`fields`>>
I despise hard-coding links, but unfortunately our doc build thinks it's smart and adds text to the link. You end up with this monstrosity when you don't specify link text:
You might not have noticed this before because the doc build only adds the link text if you're pointing to a sub-section. (And the logic for deciding whether something is a sub-section depends not just on the heading level that you use in the asciidoc source, but also the chunk level.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come this works correctly in master: https://www.elastic.co/guide/en/beats/heartbeat/master/configuration-heartbeat-options.html#monitor-fields-under-root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@urso It works because Clint is amazing. I complained about the behavior again yesterday, and he fixed it! elastic/docs@e427db2
LGTM. Just one minor comment about the link. I've already fixed the problem in the output config topic. I guess it probably needs to be fixed in master, too. |
Not too happy to modify cherry picks. I'd rather update master and cherry pick the change in master into 6.0 branch, after this one has been merged. |
@dedemorton see #4919 |
- remove removed settings in libbeat/filebeat docs - add tags/fields/fields_under_root/processor settings to every beat (cherry picked from commit 2c07801)
Cherry-pick of PR #4753 to 6.0 branch. Original message: