[Sharepoint server] crawl the root site #2141
Conversation
There was a problem hiding this comment.
Thank you for your contribution, @sjors101!
Change looks good to me, we'll test it on our side against a real Sharepoint Server instance and will get back to you!
| @@ -92,7 +92,12 @@ def __init__(self, configuration): | |||
| self.certificate = self.configuration["ssl_ca"] | |||
| self.ssl_enabled = self.configuration["ssl_enabled"] | |||
| self.retry_count = self.configuration["retry_count"] | |||
| self.site_collections = self.configuration["site_collections"] | |||
|
|
|||
| self.site_collections_path = [] | |||
There was a problem hiding this comment.
| self.site_collections_path = [] | |
| self.site_collection_paths = [] |
I'd probably rename it like this to indicate that it's an array
|
buildkite test this |
|
Tested the change, all looks good, thank you for your contribution, @sjors101! |
|
buildkite test this |
|
buildkite test this |
|
@sjors101 be sure to consider joining our contributor program! You can get credit for both the bug you filed and this PR. As a side note, we'd like to congratulate you, as the first non-Elastic-affiliated contributor to Connectors. If we were a restaurant, we'd pin this code diff to our wall. :) We're very excited about your contribution! |
|
Thanks @seanstory and @artem-shelkovnikov. The connector-framework is developing quite nicely, and the instructions in the contribution guide are great. We use various connectors intensively, expect more contributions coming your way :) |
Closes #2140
Support crawling and an indexing top-level site collection from Sharepoint server on-premise. Use the existing input field
site_collectionsto have the option to define the toplevel (root) site: example input:foo, bar, /. Tested agains the Sharepoint 2019 (16.0.0.10337: 1).Checklists
Pre-Review Checklist
v7.13.2,v7.14.0,v8.0.0)Release Note
[Added by Artem]
It's now possible to crawl root site collection with Sharepoint Server connector - before it was possible to crawl only sub-sites of the root collection