Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip checking Kibana links that are on www.elastic.co but not docs links #2081

Closed
gtback opened this issue Mar 16, 2021 · 0 comments · Fixed by #2085
Closed

Skip checking Kibana links that are on www.elastic.co but not docs links #2081

gtback opened this issue Mar 16, 2021 · 0 comments · Fixed by #2085
Assignees
@gtback
Labels
link-checking Link Checking & Redirects

Comments

@gtback
Copy link
Member

gtback commented Mar 16, 2021

The Kibana link checking process looks for URLs containing ${ELASTIC_WEBSITE_URL} and tries to check those links. For pages outside the docs (blog pages, marketing pages), these will result in false-positives for the link-checker, which is preventing elastic/kibana#94274 from passing. That PR should be the ultimate fix for #1805.
@gtback gtback mentioned this issue Mar 16, 2021
Closed
@gtback gtback self-assigned this Mar 16, 2021
@gtback gtback added the link-checking Link Checking & Redirects label Mar 16, 2021
gtback added a commit that referenced this issue Mar 16, 2021
@gtback
Improve link extraction for Kibana link checking.
fecb18e 
- Ignore links to web content that's outside the docs
- Ensure Elasticsearch Reference content is checked

Fixes #2081
@gtback gtback mentioned this issue Mar 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtback gtback

Labels
link-checking Link Checking & Redirects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve link extraction for Kibana link checking elastic/docs
1 participant
@gtback