Improve link extraction for Kibana link checking #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ignore links to web content that's outside the docs - Ensure Elasticsearch Reference content is checked Fixes #2081
|
I don't trust my Perl skills, so there's probably a better way to do these regular expressions. I tested this locally with a copy of |
nik9000
approved these changes
Mar 16, 2021
There was a problem hiding this comment.
LGTM. I'd always hoped repos could standardize on this sort of thing but I think that's not really a thing we can expect a ton of at this point.
I know that there are tests for this sort of thing off in ruby land. It'd probably be worth adding one just in case.
|
It's not the perl I'm confident in. It's that Greg tested it. It looks
idiomatic enough for me though.
…On Tue, Mar 16, 2021 at 5:06 PM Tyler Langlois ***@***.***> wrote:
***@***.**** approved this pull request.
Oh my, perl is very much out of my wheelhouse. But I have implicit
confidence in @nik9000 <https://github.com/nik9000>'s confidence
:recursive-approval:
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2085 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABUXIRMTCUJPTTEW5TIHOTTD7B5JANCNFSM4ZJG4T2A>
.
|
gtback
added a commit
that referenced
this pull request
Mar 17, 2021
When tested against a version of this repo prior to when #2085 was merged, it fails with these errors: ``` rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:5:1]' # building all books when broken link detection is enabled when there is a link in kibana to the website outside the guide logs that all the links are ok rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:1]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs there are bad cross document links rspec './integtest/spec/all_books_broken_link_detection_spec.rb[1:2:6:2]' # building all books when broken link detection is enabled when there is a broken Elasticsearch reference link in Kibana logs the bad link ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2081
Related: elastic/kibana#94274, #1805